Skip to content

Move RentReturnRelease_SubsequentRentReturnsDifferentHandles out of process #1960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 26, 2022
Merged

Move RentReturnRelease_SubsequentRentReturnsDifferentHandles out of process #1960

merged 3 commits into from
Jan 26, 2022

Conversation

@antonfirsov
Copy link
Member

@antonfirsov antonfirsov commented Jan 25, 2022

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Possible cause is that this test can race for particular memory areas with potential parallel tests, this change should fix that.
Also attempting to enable it on Mac.

@JimBobSquarePants JimBobSquarePants merged commit ffa35c3 into master Jan 26, 2022
@JimBobSquarePants JimBobSquarePants deleted the af/externalize-RentReturnRelease_SubsequentRentReturnsDifferentHandles branch January 26, 2022 05:15
@JimBobSquarePants JimBobSquarePants added this to the 2.0.0 milestone Jan 26, 2022
@antonfirsov
Copy link
Member Author

antonfirsov commented Jan 26, 2022

I should have marked this WIP until a couple of runs prove bbbf687 is stable on Mac, which doesn't seem the case - see #1958 😞 .

@antonfirsov antonfirsov mentioned this pull request Jan 26, 2022
Merged
4 tasks
@JimBobSquarePants
Copy link
Member

JimBobSquarePants commented Jan 27, 2022

DAMMIT. Sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JimBobSquarePants JimBobSquarePants JimBobSquarePants approved these changes

Assignees

No one assigned

Labels

unit tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@antonfirsov @JimBobSquarePants