Remove HistogramEqualizationOptions.Default#1840
Merged
antonfirsov merged 2 commits intomasterfrom Nov 19, 2021
Merged
Conversation
antonfirsov
commented
Nov 19, 2021
|
|
||
| Assert.Equal(expected, actual); | ||
| } | ||
| } |
Member
Author
There was a problem hiding this comment.
Unrelated tabs -> spaces change.
JimBobSquarePants
approved these changes
Nov 19, 2021
Member
JimBobSquarePants
left a comment
JimBobSquarePants
left a comment
There was a problem hiding this comment.
Yeah, this shouldn’t exist. Good catch!
Codecov Report
@@ Coverage Diff @@
## master #1840 +/- ##
======================================
Coverage 87% 87%
======================================
Files 937 937
Lines 48421 48420 -1
Branches 6054 6054
======================================
+ Hits 42223 42255 +32
+ Misses 5193 5160 -33
Partials 1005 1005
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
antonfirsov
deleted the
af/remove-HistogramEqualizationOptions-Default
branch
This was referenced Jul 23, 2025
This was referenced Jul 30, 2025
This was referenced Sep 23, 2025
This was referenced Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
We should not expose an arbitrary mutable variable like this. The common practice in the library is to use constructor to new-up instances of similar
XyzOptionsobjects.