Skip to content

Conversation

@brianpopow
Copy link
Collaborator

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Adds a check for Avx2 in ResizeKernel, fix for #1546


FeatureTestRunner.RunWithHwIntrinsicsFeature(
RunTest,
HwIntrinsics.AllowAll | HwIntrinsics.DisableAVX2 | HwIntrinsics.DisableFMA);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely! ❤️

@codecov
Copy link

codecov bot commented Feb 13, 2021

Codecov Report

Merging #1548 (649050e) into master (3be7ad0) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1548      +/-   ##
==========================================
+ Coverage   70.59%   70.62%   +0.02%     
==========================================
  Files         742      742              
  Lines       32830    32830              
  Branches     3667     3667              
==========================================
+ Hits        23177    23186       +9     
+ Misses       8938     8930       -8     
+ Partials      715      714       -1     
Flag Coverage Δ
unittests 70.62% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ssing/Processors/Transforms/Resize/ResizeKernel.cs 55.73% <100.00%> (+14.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3be7ad0...649050e. Read the comment docs.

@brianpopow brianpopow merged commit 5f8f082 into master Feb 13, 2021
@brianpopow brianpopow deleted the bp/fix1546 branch February 13, 2021 06:27
@antonfirsov
Copy link
Member

Wow guys, that was fast!

@JimBobSquarePants
Copy link
Member

Open source bebe!

JimBobSquarePants pushed a commit that referenced this pull request Mar 13, 2021
Add check for Avx2 in ResizeKernel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants