Auto repair Png options to use Bit8. #1395
Merged
JimBobSquarePants merged 1 commit intomasterfrom Oct 21, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1395 +/- ##
==========================================
+ Coverage 82.87% 82.88% +0.01%
==========================================
Files 690 690
Lines 30903 30903
Branches 3545 3544 -1
==========================================
+ Hits 25610 25614 +4
+ Misses 4572 4570 -2
+ Partials 721 719 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
JimBobSquarePants
added a commit
that referenced
this pull request
Mar 13, 2021
Auto repair Png options to use Bit8.
This was referenced Jul 30, 2025
This was referenced Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Fixes #935
Rather than throwing when ColorType/BitDepth options are passed that are not supported by the PNG specification we can use
PngBitDepth.Bit8to fix up the options.This bit depth is the only one supported by all color type values.