Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1385 +/- ##
=======================================
Coverage 82.83% 82.83%
=======================================
Files 690 690
Lines 30847 30843 -4
Branches 3542 3542
=======================================
- Hits 25551 25550 -1
+ Misses 4574 4572 -2
+ Partials 722 721 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
JimBobSquarePants
changed the title
antonfirsov
approved these changes
Oct 16, 2020
Member
antonfirsov
left a comment
antonfirsov
left a comment
There was a problem hiding this comment.
Looks good. Let's see where this concept brings us.
JimBobSquarePants
added a commit
that referenced
this pull request
Mar 13, 2021
Advanced Feature Testing
This was referenced Jul 30, 2025
This was referenced Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
As we add more hardware intrinsics into the library we need a good way to test them.
Ideally we want to follow the same pattern the runtime uses for abstracting intrinsics so our tests should be able to call the same method multiple times with difference features disabled.
This PR adds two bits of functionality that allow this pattern
FeatureTestRunner.RunWithHwIntrinsicsFeature. Which utilizesRemoteExecutor+ environmental constants to disable intrinsics features.HwIntrinsics_SSE_AVXwhich is the first implementation of config classes for benchmarking a single method with separate runs utilizing environmental constants to disable intrinsics features.