Skip to content

Conversation

@Turnerj
Copy link
Contributor

@Turnerj Turnerj commented Jun 17, 2020

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Adds a Third Party Notices file, closes #856 . Opening language copied from dotnet/runtime, license information copied from the various sources in the code base.

One thing to note, the shared infrastructure repo also has a file with MIT and BSD licensing. I didn't include that reference here as I see the shared infrastructure to be its own dependency. It probably deserves to have its own Third Party Notices file.

@Turnerj
Copy link
Contributor Author

Turnerj commented Jun 17, 2020

Also not sure if it is then worth then keeping the same license references in the code (like the CoreFX Stream extensions) or a sub-readme (like Zlib). You could just refer them to this Third Party Notices file instead.

@codecov
Copy link

codecov bot commented Jun 17, 2020

Codecov Report

Merging #1236 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1236   +/-   ##
=======================================
  Coverage   82.54%   82.54%           
=======================================
  Files         697      697           
  Lines       30511    30511           
  Branches     3469     3469           
=======================================
  Hits        25186    25186           
  Misses       4605     4605           
  Partials      720      720           
Flag Coverage Δ
#unittests 82.54% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53da0e5...d16708c. Read the comment docs.

@JimBobSquarePants
Copy link
Member

Also not sure if it is then worth then keeping the same license references in the code (like the CoreFX Stream extensions) or a sub-readme (like Zlib). You could just refer them to this Third Party Notices file instead.

Let's keep them as-is for the time being. This is great!

@JimBobSquarePants JimBobSquarePants merged commit d074b72 into SixLabors:master Jun 17, 2020
@Turnerj Turnerj deleted the third-party-notices branch June 18, 2020 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider adding a THIRD-PARTY-NOTICES.TXT file

2 participants