Try to fix corflags.exe failures on CI #1134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Damn, this has the changes from #1130, I think will do some evil things to overcome this. |
4 tasks
Codecov Report
@@ Coverage Diff @@
## master #1134 +/- ##
=======================================
Coverage 82.22% 82.22%
=======================================
Files 678 678
Lines 29116 29116
Branches 3300 3300
=======================================
Hits 23942 23942
Misses 4479 4479
Partials 695 695
Continue to review full report at Codecov.
|
…geSharp into af/corflags-tweaks
Member
Author
|
@JimBobSquarePants 3/3 successful full test runs so far on 32bit Framework. Looks like it worked! |
Member
|
@antonfirsov Awesome! Let's get it merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Things went wrong with the MemoryGroup PR. Theory: new codec tests (BMP, PNG) using
RemoteExecutorwere not callingPrepareRemoteExecutor(), which resulted in a condition whereEnsureRemoteExecutorIs32Bit()tried to modifyRemoteExecutor.exeafter it has been already loaded by the process.Let's see if this tweak can fix this.