Skip to content

Conversation

@JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

This PR replaces #857 and fixes #650 by adding the ability to pass custom configuration to all processing operations.

Copy link
Collaborator

@brianpopow brianpopow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@codecov
Copy link

codecov bot commented Jan 7, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@d7eeb2f). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1070   +/-   ##
=========================================
  Coverage          ?   89.83%           
=========================================
  Files             ?     1200           
  Lines             ?    53010           
  Branches          ?     3844           
=========================================
  Hits              ?    47621           
  Misses            ?     4561           
  Partials          ?      828
Impacted Files Coverage Δ
...adata/Profiles/Exif/Tags/ExifTag.SignedRational.cs 100% <ø> (ø)
...eSharp/Metadata/Profiles/Exif/Values/ExifValues.cs 96.61% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7eeb2f...a5ab02c. Read the comment docs.

@JimBobSquarePants JimBobSquarePants merged commit 92f3ada into master Jan 7, 2020
@JimBobSquarePants JimBobSquarePants deleted the js/custom-configuration-fix-650 branch January 7, 2020 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow passing custom Configuration instances to processors

3 participants