Skip to content

Conversation

@JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Turns out this had been fixed before but somehow regressed. I've re-added the fix and added a test reference image to ensure it does not regress again.

@antonfirsov When you have some time I'd like to chat to you about this comment I discovered during investigation.

// To reintroduce parallel processing, we to launch multiple workers

Amazing work getting the performance you have done in series. Do you think we should reintroduce parallelism here?

@codecov
Copy link

codecov bot commented Dec 5, 2019

Codecov Report

Merging #1060 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1060   +/-   ##
=======================================
  Coverage   89.94%   89.94%           
=======================================
  Files        1131     1131           
  Lines       50619    50619           
  Branches     3715     3715           
=======================================
  Hits        45528    45528           
  Misses       4335     4335           
  Partials      756      756

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1017121...674815c. Read the comment docs.

Copy link
Member

@tocsoft tocsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@JimBobSquarePants JimBobSquarePants merged commit 9275555 into master Dec 8, 2019
@JimBobSquarePants JimBobSquarePants deleted the js/fix-1006 branch December 8, 2019 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants