Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1005 +/- ##
==========================================
- Coverage 89.77% 89.66% -0.12%
==========================================
Files 1098 1098
Lines 48810 48819 +9
Branches 3433 3438 +5
==========================================
- Hits 43821 43772 -49
- Misses 4284 4292 +8
- Partials 705 755 +50
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1005 +/- ##
==========================================
- Coverage 89.86% 89.85% -0.01%
==========================================
Files 1098 1098
Lines 48851 48863 +12
Branches 3428 3433 +5
==========================================
+ Hits 43898 43908 +10
- Misses 4252 4254 +2
Partials 701 701
Continue to review full report at Codecov.
|
antonfirsov
reviewed
Sep 8, 2019
Member
antonfirsov
left a comment
There was a problem hiding this comment.
Minor CQ related comment, but otherwise looks good. (My knowledge of PNG is limited though.)
antonfirsov
pushed a commit
to antonfirsov/ImageSharp
that referenced
this pull request
Nov 11, 2019
This was referenced Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Fixes #1004 Changes the behavior of the
ZlibInflateStreamto throw only when operating on a critical chunk.