refactor to follow style rules

Author: Poker-sang

src/ImageSharp/Formats/Webp/AlphaDecoder.cs

@@ -59,7 +59,7 @@ public AlphaDecoder(int width, int height, IMemoryOwner<byte> data, byte alphaCh
 
         if (this.Compressed)
         {
-            Vp8LBitReader bitReader = new(data);
+            Vp8LBitReader bitReader = new Vp8LBitReader(data);
             this.LosslessDecoder = new WebpLosslessDecoder(bitReader, memoryAllocator, configuration);
             this.LosslessDecoder.DecodeImageStream(this.Vp8LDec, width, height, true);
 

src/ImageSharp/Formats/Webp/AlphaEncoder.cs

@@ -43,17 +43,8 @@ public static IMemoryOwner<byte> EncodeAlpha<TPixel>(
         {
             const WebpEncodingMethod effort = WebpEncodingMethod.Default;
             const int quality = 8 * (int)effort;
-            using Vp8LEncoder lossLessEncoder = new(
-                memoryAllocator,
-                configuration,
-                width,
-                height,
-                quality,
-                skipMetadata,
-                effort,
-                WebpTransparentColorMode.Preserve,
-                false,
-                0);
+            using Vp8LEncoder lossLessEncoder = new Vp8LEncoder(memoryAllocator, configuration, width, height, quality,
+                skipMetadata, effort, WebpTransparentColorMode.Preserve, false, 0);
 
             // The transparency information will be stored in the green channel of the ARGB quadruplet.
             // The green channel is allowed extra transformation steps in the specification -- unlike the other channels,
@@ -81,7 +72,7 @@ private static ImageFrame<Rgba32> DispatchAlphaToGreen<TPixel>(ImageFrame<TPixel
     {
         int width = frame.Width;
         int height = frame.Height;
-        ImageFrame<Rgba32> alphaAsFrame = new(Configuration.Default, width, height);
+        ImageFrame<Rgba32> alphaAsFrame = new ImageFrame<Rgba32>(Configuration.Default, width, height);
 
         for (int y = 0; y < height; y++)
         {
@@ -91,7 +82,7 @@ private static ImageFrame<Rgba32> DispatchAlphaToGreen<TPixel>(ImageFrame<TPixel
             for (int x = 0; x < width; x++)
             {
                 // Leave A/R/B channels zero'd.
-                pixelRow[x] = new(0, alphaRow[x], 0, 0);
+                pixelRow[x] = new Rgba32(0, alphaRow[x], 0, 0);
             }
         }
 

src/ImageSharp/Formats/Webp/AnimationFrameData.cs

@@ -62,7 +62,7 @@ public static AnimationFrameData Parse(BufferedReadStream stream)
     {
         Span<byte> buffer = stackalloc byte[4];
 
-        AnimationFrameData data = new()
+        AnimationFrameData data = new AnimationFrameData
         {
             DataSize = WebpChunkParsingUtils.ReadChunkSize(stream, buffer),
 

src/ImageSharp/Formats/Webp/BitWriter/Vp8BitWriter.cs

@@ -399,7 +399,7 @@ public override void WriteEncodedImageToStream(Stream stream)
         int mbSize = this.enc.Mbw * this.enc.Mbh;
         int expectedSize = (int)((uint)mbSize * 7 / 8);
 
-        Vp8BitWriter bitWriterPartZero = new(expectedSize, this.enc);
+        Vp8BitWriter bitWriterPartZero = new Vp8BitWriter(expectedSize, this.enc);
 
         // Partition #0 with header and partition sizes.
         uint size0 = bitWriterPartZero.GeneratePartition0();
@@ -545,7 +545,7 @@ private void WriteProbas()
     // Writes the partition #0 modes (that is: all intra modes)
     private void CodeIntraModes()
     {
-        Vp8EncIterator it = new(this.enc);
+        Vp8EncIterator it = new Vp8EncIterator(this.enc);
         int predsWidth = this.enc.PredsWidth;
 
         do

src/ImageSharp/Formats/Webp/BitWriter/Vp8LBitWriter.cs

@@ -102,7 +102,7 @@ public Vp8LBitWriter Clone()
     {
         byte[] clonedBuffer = new byte[this.Buffer.Length];
         System.Buffer.BlockCopy(this.Buffer, 0, clonedBuffer, 0, this.cur);
-        return new(clonedBuffer, this.bits, this.used, this.cur);
+        return new Vp8LBitWriter(clonedBuffer, this.bits, this.used, this.cur);
     }
 
     /// <inheritdoc/>

src/ImageSharp/Formats/Webp/Lossless/BackwardReferenceEncoder.cs

@@ -775,7 +775,7 @@ private static void BackwardReferencesRle(int xSize, int ySize, ReadOnlySpan<uin
     private static void BackwardRefsWithLocalCache(ReadOnlySpan<uint> bgra, int cacheBits, Vp8LBackwardRefs refs)
     {
         int pixelIndex = 0;
-        ColorCache colorCache = new(cacheBits);
+        ColorCache colorCache = new ColorCache(cacheBits);
         for (int idx = 0; idx < refs.Refs.Count; idx++)
         {
             PixOrCopy v = refs.Refs[idx];

src/ImageSharp/Formats/Webp/Lossless/CostManager.cs

@@ -17,7 +17,7 @@ internal sealed class CostManager : IDisposable
 
     private const int FreeIntervalsStartCount = 25;
 
-    private readonly Stack<CostInterval> freeIntervals = new(FreeIntervalsStartCount);
+    private readonly Stack<CostInterval> freeIntervals = new Stack<CostInterval>(FreeIntervalsStartCount);
 
     public CostManager(MemoryAllocator memoryAllocator, IMemoryOwner<ushort> distArray, int pixCount, CostModel costModel)
     {

src/ImageSharp/Formats/Webp/Lossless/PixOrCopy.cs

@@ -15,22 +15,23 @@ internal sealed class PixOrCopy
     public uint BgraOrDistance { get; set; }
 
     public static PixOrCopy CreateCacheIdx(int idx) =>
-        new()
+        new PixOrCopy
         {
             Mode = PixOrCopyMode.CacheIdx,
             BgraOrDistance = (uint)idx,
             Len = 1
         };
 
     public static PixOrCopy CreateLiteral(uint bgra) =>
-        new()
+        new PixOrCopy
         {
             Mode = PixOrCopyMode.Literal,
             BgraOrDistance = bgra,
             Len = 1
         };
 
-    public static PixOrCopy CreateCopy(uint distance, ushort len) => new()
+    public static PixOrCopy CreateCopy(uint distance, ushort len) =>
+        new PixOrCopy
     {
         Mode = PixOrCopyMode.Copy,
         BgraOrDistance = distance,

src/ImageSharp/Formats/Webp/Lossless/Vp8LEncoder.cs

@@ -304,7 +304,7 @@ public void Encode<TPixel>(ImageFrame<TPixel> frame, Stream stream, bool hasAnim
 
         if (hasAnimation)
         {
-            prevPosition = BitWriterBase.WriteAnimationFrame(stream, new()
+            prevPosition = BitWriterBase.WriteAnimationFrame(stream, new AnimationFrameData
             {
                 Width = (uint)frame.Width,
                 Height = (uint)frame.Height,
@@ -547,7 +547,7 @@ private CrunchConfig[] EncoderAnalyze(ReadOnlySpan<uint> bgra, int width, int he
         EntropyIx entropyIdx = this.AnalyzeEntropy(bgra, width, height, usePalette, this.PaletteSize, this.TransformBits, out redAndBlueAlwaysZero);
 
         bool doNotCache = false;
-        List<CrunchConfig> crunchConfigs = new();
+        List<CrunchConfig> crunchConfigs = new List<CrunchConfig>();
 
         if (this.method == WebpEncodingMethod.BestQuality && this.quality == 100)
         {
@@ -641,8 +641,8 @@ private void EncodeImage(int width, int height, bool useCache, CrunchConfig conf
             Vp8LBackwardRefs refsTmp = this.Refs[refsBest.Equals(this.Refs[0]) ? 1 : 0];
 
             this.bitWriter.Reset(bwInit);
-            Vp8LHistogram tmpHisto = new(cacheBits);
-            List<Vp8LHistogram> histogramImage = new(histogramImageXySize);
+            Vp8LHistogram tmpHisto = new Vp8LHistogram(cacheBits);
+            List<Vp8LHistogram> histogramImage = new List<Vp8LHistogram>(histogramImageXySize);
             for (int i = 0; i < histogramImageXySize; i++)
             {
                 histogramImage.Add(new Vp8LHistogram(cacheBits));
@@ -839,9 +839,9 @@ private void EncodeImageNoHuffman(Span<uint> bgra, Vp8LHashChain hashChain, Vp8L
             refsTmp1,
             refsTmp2);
 
-        List<Vp8LHistogram> histogramImage = new()
+        List<Vp8LHistogram> histogramImage = new List<Vp8LHistogram>
         {
-            new(cacheBits)
+            new Vp8LHistogram(cacheBits)
         };
 
         // Build histogram image and symbols from backward references.
@@ -941,7 +941,7 @@ private void StoreFullHuffmanCode(Span<HuffmanTree> huffTree, HuffmanTreeToken[]
         int i;
         byte[] codeLengthBitDepth = new byte[WebpConstants.CodeLengthCodes];
         short[] codeLengthBitDepthSymbols = new short[WebpConstants.CodeLengthCodes];
-        HuffmanTreeCode huffmanCode = new()
+        HuffmanTreeCode huffmanCode = new HuffmanTreeCode
         {
             NumSymbols = WebpConstants.CodeLengthCodes,
             CodeLengths = codeLengthBitDepth,
@@ -1192,7 +1192,7 @@ private EntropyIx AnalyzeEntropy(ReadOnlySpan<uint> bgra, int width, int height,
         histo[(int)HistoIx.HistoBluePred * 256]++;
         histo[(int)HistoIx.HistoAlphaPred * 256]++;
 
-        Vp8LBitEntropy bitEntropy = new();
+        Vp8LBitEntropy bitEntropy = new Vp8LBitEntropy();
         for (int j = 0; j < (int)HistoIx.HistoTotal; j++)
         {
             bitEntropy.Init();
@@ -1318,7 +1318,7 @@ private bool AnalyzeAndCreatePalette(ReadOnlySpan<uint> bgra, int width, int hei
     /// <returns>The number of palette entries.</returns>
     private static int GetColorPalette(ReadOnlySpan<uint> bgra, int width, int height, Span<uint> palette)
     {
-        HashSet<uint> colors = new();
+        HashSet<uint> colors = new HashSet<uint>();
         for (int y = 0; y < height; y++)
         {
             ReadOnlySpan<uint> bgraRow = bgra.Slice(y * width, width);

src/ImageSharp/Formats/Webp/Lossless/WebpLosslessDecoder.cs

@@ -95,7 +95,7 @@ public WebpLosslessDecoder(Vp8LBitReader bitReader, MemoryAllocator memoryAlloca
     public void Decode<TPixel>(Buffer2D<TPixel> pixels, int width, int height)
         where TPixel : unmanaged, IPixel<TPixel>
     {
-        using (Vp8LDecoder decoder = new(width, height, this.memoryAllocator))
+        using (Vp8LDecoder decoder = new Vp8LDecoder(width, height, this.memoryAllocator))
         {
             this.DecodeImageStream(decoder, width, height, true);
             this.DecodeImageData(decoder, decoder.Pixels.Memory.Span);
@@ -616,7 +616,7 @@ private void ReadHuffmanCodeLengths(Span<HuffmanCode> table, int[] codeLengthCod
     private void ReadTransformation(int xSize, int ySize, Vp8LDecoder decoder)
     {
         Vp8LTransformType transformType = (Vp8LTransformType)this.bitReader.ReadValue(2);
-        Vp8LTransform transform = new(transformType, xSize, ySize);
+        Vp8LTransform transform = new Vp8LTransform(transformType, xSize, ySize);
 
         // Each transform is allowed to be used only once.
         foreach (Vp8LTransform decoderTransform in decoder.Transforms)