Packaged code for PyPI by [jafarkmi] #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IshaanDesai
reviewed
Dec 5, 2024
README.md
Outdated
| ## Installing the package | ||
|
|
||
| ### Using pip3 to install from PyPI | ||
|
|
||
| `` pip3 install jafarkmi_diffusion2d`` |
There was a problem hiding this comment.
Would this really work? Remember that you deployed your package to TestPyPI and not PyPI.
There was a problem hiding this comment.
You are right Ishaan, it should be
pip install -i https://test.pypi.org/simple/ jafarkmi-diffusion2d==0.0.7
IshaanDesai
reviewed
Dec 5, 2024
| ## Running this package | ||
|
|
||
| ```python | ||
| from jafarkmi_diffusion2d import solve |
There was a problem hiding this comment.
This command did not work for me:
>>> from jafarkmi_diffusion2d import solve
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
ImportError: cannot import name 'solve' from 'jafarkmi_diffusion2d' (/usr/local/lib/python3.8/dist-packages/jafarkmi_diffusion2d/__init__.py)instead, from jafarkmi_diffusion2d.diffusion2d import solve worked.
There was a problem hiding this comment.
Yes, you are right, it should be either :
`from jafarkmi_diffusion2d import diffusion2d
diffusion2d.solve(dx,dy,D)`
or
`from jafarkmi_diffusion2d. diffusion2d import solve
solve(dx,dy,D)`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.