Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't display dependent useless information #16

Merged
merged 1 commit into from
Oct 1, 2022
Merged

Don't display dependent useless information #16

merged 1 commit into from
Oct 1, 2022

Conversation

cerus
Copy link
Contributor

@cerus cerus commented Oct 1, 2022

This pr resolves #13.

Changes

  • JOB_SITE will only be shown if the villager has a profession
  • LAST_WORKED will only be shown if the villager has a profession and a work site
  • LAST_SLEPT will only be shown if the villager has a bed
  • RESTOCKS will only be shown if the villager has a profession and a work site
  • Fixed a small bug where LAST_SLEPT messages would only be shown if the LAST_WORKED setting was enabled

RhythmicSys
RhythmicSys approved these changes Oct 1, 2022
View reviewed changes
Copy link
Member

@RhythmicSys RhythmicSys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@RhythmicSys RhythmicSys merged commit 8cd756c into Simplexity-Development:master Oct 1, 2022
@RhythmicSys RhythmicSys added the Hacktoberfest-Accepted Accepted for Hacktoberfest-2022 label Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RhythmicSys RhythmicSys RhythmicSys approved these changes

Assignees
No one assigned
Labels
Hacktoberfest-Accepted Accepted for Hacktoberfest-2022
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid Generating Useless Dependent Information
2 participants
@cerus @RhythmicSys