Add functional test for disabling finishes_command_before_handling_next middleware

Author: scaytrase

tests/Functional/NestedCommandExecutionOrderConfigurationTest.php

@@ -0,0 +1,85 @@
+<?php
+
+namespace SimpleBus\SymfonyBridge\Tests\Functional;
+
+use SimpleBus\SymfonyBridge\Tests\Functional\SmokeTest\Nested\NestedCommand;
+use SimpleBus\SymfonyBridge\Tests\Functional\SmokeTest\Nested\PostExecutionRecord;
+use SimpleBus\SymfonyBridge\Tests\Functional\SmokeTest\Nested\PreExecutionRecord;
+use SimpleBus\SymfonyBridge\Tests\Functional\SmokeTest\Nested\RecordsBag;
+use SimpleBus\SymfonyBridge\Tests\Functional\SmokeTest\TestKernel;
+use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
+
+final class NestedCommandExecutionOrderConfigurationTest extends KernelTestCase
+{
+    protected static function getKernelClass(): string
+    {
+        return TestKernel::class;
+    }
+
+    /**
+     * @test
+     */
+    public function nested_commands_are_executed_sequentially_by_default(): void
+    {
+        self::bootKernel(['environment' => 'config1']);
+        $container = self::$kernel->getContainer();
+
+        $commandBus = $container->get('command_bus');
+        $command = new NestedCommand();
+        $commandBus->handle($command);
+
+        /** @var RecordsBag $recorder */
+        $recorder = $container->get('nesting_records_bag');
+
+        $this->assertEquals(
+            [
+                new PreExecutionRecord(0),
+                new PostExecutionRecord(0),
+                new PreExecutionRecord(1),
+                new PostExecutionRecord(1),
+                new PreExecutionRecord(2),
+                new PostExecutionRecord(2),
+
+            ],
+            $recorder->records
+        );
+    }
+
+    /**
+     * @test
+     */
+    public function disabling_finishes_command_before_handling_next_middleware_keeps_command_nesting(): void
+    {
+        self::bootKernel(['environment' => 'config3']);
+        $container = self::$kernel->getContainer();
+
+        $commandBus = $container->get('command_bus');
+        $command = new NestedCommand();
+        $commandBus->handle($command);
+
+        /** @var RecordsBag $recorder */
+        $recorder = $container->get('nesting_records_bag');
+
+        $this->assertEquals(
+            [
+                new PreExecutionRecord(0),
+                new PreExecutionRecord(1),
+                new PreExecutionRecord(2),
+                new PostExecutionRecord(2),
+                new PostExecutionRecord(1),
+                new PostExecutionRecord(0),
+
+            ],
+            $recorder->records
+        );
+    }
+
+    /** {@inheritdoc} */
+    protected function tearDown()
+    {
+        parent::tearDown();
+
+        static::$class = null;
+        static::$kernel = null;
+    }
+}

tests/Functional/SmokeTest/Nested/NestedCommand.php

@@ -0,0 +1,13 @@
+<?php
+
+namespace SimpleBus\SymfonyBridge\Tests\Functional\SmokeTest\Nested;
+
+final class NestedCommand
+{
+    public $level;
+
+    public function __construct(int $level = 0)
+    {
+        $this->level = $level;
+    }
+}

tests/Functional/SmokeTest/Nested/NestedCommandHandler.php

@@ -0,0 +1,39 @@
+<?php
+
+namespace SimpleBus\SymfonyBridge\Tests\Functional\SmokeTest\Nested;
+
+use SimpleBus\Message\Bus\MessageBus;
+
+final class NestedCommandHandler
+{
+    /**
+     * @var int
+     */
+    private $maxNestingLevel;
+    /**
+     * @var RecordsBag
+     */
+    private $recordsBag;
+    /**
+     * @var MessageBus
+     */
+    private $commandBus;
+
+    public function __construct(MessageBus $commandBus, RecordsBag $recordsBag, int $maxNestingLevel)
+    {
+        $this->commandBus = $commandBus;
+        $this->recordsBag = $recordsBag;
+        $this->maxNestingLevel = $maxNestingLevel;
+    }
+
+    public function handle(NestedCommand $command): void
+    {
+        $this->recordsBag->records[] = new PreExecutionRecord($command->level);
+
+        if ($command->level < $this->maxNestingLevel) {
+            $this->commandBus->handle(new NestedCommand($command->level + 1));
+        }
+
+        $this->recordsBag->records[] = new PostExecutionRecord($command->level);
+    }
+}

tests/Functional/SmokeTest/Nested/PostExecutionRecord.php

@@ -0,0 +1,14 @@
+<?php
+
+namespace SimpleBus\SymfonyBridge\Tests\Functional\SmokeTest\Nested;
+
+final class PostExecutionRecord
+{
+    /** @var int */
+    public $level;
+
+    public function __construct(int $level)
+    {
+        $this->level = $level;
+    }
+}

tests/Functional/SmokeTest/Nested/PreExecutionRecord.php

@@ -0,0 +1,14 @@
+<?php
+
+namespace SimpleBus\SymfonyBridge\Tests\Functional\SmokeTest\Nested;
+
+final class PreExecutionRecord
+{
+    /** @var int */
+    public $level;
+
+    public function __construct(int $level)
+    {
+        $this->level = $level;
+    }
+}

tests/Functional/SmokeTest/Nested/RecordsBag.php

@@ -0,0 +1,8 @@
+<?php
+
+namespace SimpleBus\SymfonyBridge\Tests\Functional\SmokeTest\Nested;
+
+final class RecordsBag
+{
+    public $records;
+}

tests/Functional/SmokeTest/config1.yml

@@ -37,6 +37,20 @@ services:
             - '@command_bus'
         public: true
 
+    nesting_command_handler:
+        class: SimpleBus\SymfonyBridge\Tests\Functional\SmokeTest\Nested\NestedCommandHandler
+        arguments:
+            - '@command_bus'
+            - '@nesting_records_bag'
+            - 2
+        tags:
+            - { name: command_handler, handles: SimpleBus\SymfonyBridge\Tests\Functional\SmokeTest\Nested\NestedCommand }
+        public: true
+
+    nesting_records_bag:
+        class: SimpleBus\SymfonyBridge\Tests\Functional\SmokeTest\Nested\RecordsBag
+        public: true
+
 command_bus:
     command_name_resolver_strategy: class_based
     middlewares:

tests/Functional/SmokeTest/config3.yml

@@ -0,0 +1,25 @@
+imports:
+    - { resource: config.yml }
+
+services:
+    nesting_command_handler:
+        class: SimpleBus\SymfonyBridge\Tests\Functional\SmokeTest\Nested\NestedCommandHandler
+        arguments:
+            - '@command_bus'
+            - '@nesting_records_bag'
+            - 2
+        tags:
+            - { name: command_handler, handles: SimpleBus\SymfonyBridge\Tests\Functional\SmokeTest\Nested\NestedCommand }
+        public: true
+
+    nesting_records_bag:
+        class: SimpleBus\SymfonyBridge\Tests\Functional\SmokeTest\Nested\RecordsBag
+        public: true
+
+command_bus:
+    command_name_resolver_strategy: class_based
+    middlewares:
+        finishes_command_before_handling_next: false
+
+event_bus:
+    event_name_resolver_strategy: named_message