Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NullPointerException #113

Open
frankHarmann opened this issue Apr 23, 2019 · 2 comments
Open

NullPointerException #113

frankHarmann opened this issue Apr 23, 2019 · 2 comments
Labels
feedback-needed The author needs to provide feedback because it's not clear what to do or how to reproduce the bug.

Comments

@frankHarmann
Copy link
Contributor

Steps to reproduce

unknown, happens randomly (only very sporadic)

Expected behavior

no crash

Actual behavior

<2019-04-02 13:14:52.640> Thread([28]) - AppDelegate.LogUnhandledException(Exception) (exception=System.Exception: CurrentDomainOnUnhandledException ---> System.NullReferenceException: Object reference not set to an instance of an object
at Plugin.DownloadManager.UrlSessionDownloadDelegate.DidCompleteWithError (Foundation.NSUrlSession session, Foundation.NSUrlSessionTask task, Foundation.NSError error) <0x1053747b0 + 0x00028> in <4827c03515ed4a5dbd19c33d9b81f2a1#079ea52387256c0e69a46aa087d77b95>:0
--- End of inner exception stack trace ---).

Looking at the code there probably should be null pointer check for task and error objects in all methods of UrlSessionDelegate in order to prevent nullReferenceExceptions (or try/catch/ignore wrappers).

Configuration

Platform:
iOS, develop branch

Device:
Real device (iPad Pro 3 12.9in (J321AP), iOS 12.1.4)

@SimonSimCity
Copy link
Owner

Would you have time to write a PR for this? 😉

@SimonSimCity
Copy link
Owner

Well ... according to the method that was called, there was an error, so it would be nice to know if the file could be downloaded - I guess not. But a detailed error message by iOS would help a lot. Otherwise we can only set the error-details to an empty string.

@SimonSimCity SimonSimCity added the feedback-needed The author needs to provide feedback because it's not clear what to do or how to reproduce the bug. label Aug 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback-needed The author needs to provide feedback because it's not clear what to do or how to reproduce the bug.
Projects
None yet
Development

No branches or pull requests

2 participants