Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Equivalent of --mode diff now that parameters have been removed? #48

Closed
koeninger opened this issue Nov 25, 2019 · 4 comments
Closed

Equivalent of --mode diff now that parameters have been removed? #48

koeninger opened this issue Nov 25, 2019 · 4 comments

Comments

@koeninger
Copy link

662b07b removed "parameters" as a configuration element.

I was using parameters to pass --mode diff, what is the equivalent now if I only want to format files that are modified compared to master?

For context, see e.g. https://github.com/apache/spark/pull/26655/files

@SimonJPegg
Copy link
Owner

There isn't an equivalent at the minute I'm afraid. We're using Scalafmt-dynamic to pull down the requested version and are limited to the features supported by the Scalafmt interface. I'd have to re-implement this feature within the plugin.

@SimonJPegg
Copy link
Owner

Can you try v1.0.3 and let me know if this works for you.

@koeninger
Copy link
Author

Testing it out now, thanks for the update

@SimonJPegg
Copy link
Owner

Judging by the comments on SPARK-30570, I'm assuming this is now resolved. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants