chore: final code review

dprevost-LMI · dprevost-LMI · commit d7378538d8a6 · 2024-10-06T12:03:12.000-04:00
diff --git a/src/components/Waveform/Waveform.tsx b/src/components/Waveform/Waveform.tsx
@@ -157,7 +157,7 @@ export const Waveform = forwardRef<IWaveformRef, IWaveform>((props, ref) => {
       }
     } catch (err) {
       console.error(err);
-      onError?.(err);
+      onError(err);
     }
   };
 
@@ -180,12 +180,12 @@ export const Waveform = forwardRef<IWaveformRef, IWaveform>((props, ref) => {
           }
         }
       } catch (err) {
-        onError?.(err);
+        onError(err);
         (onChangeWaveformLoadState as Function)?.(false);
         console.error(err);
       }
     } else {
-      onError?.(`Can not find waveform for mode ${mode} path: ${path}`);
+      onError(`Can not find waveform for mode ${mode} path: ${path}`);
       console.error(`Can not find waveform for mode ${mode} path: ${path}`);
     }
   };

Original file line number	Diff line number	Diff line change
`@@ -157,7 +157,7 @@ export const Waveform = forwardRef<IWaveformRef, IWaveform>((props, ref) => {`
`157`	`157`	`}`
`158`	`158`	`} catch (err) {`
`159`	`159`	`console.error(err);`
`160`		`- onError?.(err);`
	`160`	`+ onError(err);`
`161`	`161`	`}`
`162`	`162`	`};`
`163`	`163`
`@@ -180,12 +180,12 @@ export const Waveform = forwardRef<IWaveformRef, IWaveform>((props, ref) => {`
`180`	`180`	`}`
`181`	`181`	`}`
`182`	`182`	`} catch (err) {`
`183`		`- onError?.(err);`
	`183`	`+ onError(err);`
`184`	`184`	`(onChangeWaveformLoadState as Function)?.(false);`
`185`	`185`	`console.error(err);`
`186`	`186`	`}`
`187`	`187`	`} else {`
`188`		- onError?.(`Can not find waveform for mode ${mode} path: ${path}`);
	`188`	+ onError(`Can not find waveform for mode ${mode} path: ${path}`);
`189`	`189`	console.error(`Can not find waveform for mode ${mode} path: ${path}`);
`190`	`190`	`}`
`191`	`191`	`};`