update gitignore venv/* to *venv/* #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richbeales
approved these changes
Apr 11, 2023
nponeccop
approved these changes
Apr 11, 2023
sindlinger
pushed a commit
to Orgsindlinger/Auto-GPT-WebUI
that referenced
this pull request
Sep 25, 2024
…itignore update gitignore venv/* to *venv/*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
issue: #767
Changes
Changes line 10 in the .gitignore from
venv/*to*venv/*Documentation
Such a simple change is self-explanatory, not worth the clutter of a comment line in the
.gitignore. It would be better to add a section about venv in theREADME, these should be a different PR, not this one.Test Plan
I tested this PR by naming my virtual environment
Auto-GPT-venv, then pushed to a branch and confirmed the virtual environment directory was ignored.PR Quality Checklist
Thanks, gn.