chore: make prepare task configurable #5806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nityanandagohain
approved these changes
Sep 4, 2024
|
Only amol has knowledge about it. Because it is never used (by setting acquireLock=true) I removed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To be able to support anomaly alerts only in ee #5469 (comment), we need to run a separate manager in ee. The
prepareTaskfunction onManageris responsible for creating different kinds of rules depending on type. We will introduce a new rule type called anomaly and set a customprepareTaskthat includes theRuleTypeAnomalyother thanRuleTypeProm,RuleTypeThreshold.