Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: added trace detail tests #5523

Merged
merged 16 commits into from
Aug 29, 2024
Merged

chore: added trace detail tests #5523

merged 16 commits into from
Aug 29, 2024

Conversation

SagarRajput-7
Copy link
Contributor

@SagarRajput-7 SagarRajput-7 commented Jul 19, 2024 •
edited
Loading

Summary

  • Test cases covered:
    • should render tracedetail
    • should render tracedetail events tab
    • should toggle slider - selected span details
    • should be able to selected another span and see its detail
    • focus on selected span and reset focus action

Related Issues / PR's

Screenshots

NA

Affected Areas and Manually Tested Areas

@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the chore label Jul 19, 2024
@SagarRajput-7 SagarRajput-7 changed the title chore: Trace detail tests chore: added trace detail tests Jul 21, 2024
@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

vikrantgupta25
vikrantgupta25 approved these changes Aug 23, 2024
View reviewed changes
Copy link
Collaborator

@vikrantgupta25 vikrantgupta25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SagarRajput-7 SagarRajput-7 merged commit fb92ddc into develop Aug 29, 2024
11 of 12 checks passed
@SagarRajput-7 SagarRajput-7 deleted the trace-detail-tests branch August 29, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YounixM YounixM YounixM approved these changes

@vikrantgupta25 vikrantgupta25 vikrantgupta25 approved these changes

@ahmadshaheer ahmadshaheer Awaiting requested review from ahmadshaheer

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SagarRajput-7 @YounixM @ahmadshaheer @vikrantgupta25