Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Threshold does not appear to work #5262

Closed
Tracked by #3249
srikanthccv opened this issue Jun 18, 2024 · 6 comments
Closed
Tracked by #3249

Threshold does not appear to work #5262

srikanthccv opened this issue Jun 18, 2024 · 6 comments
Assignees
Labels

Comments

@srikanthccv
Copy link
Member

srikanthccv commented Jun 18, 2024

It's not clear what is thresholds supposed to do it the table panel type. It doesn't seem to work either.

https://www.loom.com/share/4bd7966d726d4f3caf4d5910b5436b96?sid=b21faea1-dcfd-40b1-bced-6cee1039a092

Copy link

request-info bot commented Jun 18, 2024

We would appreciate it if you could provide us with more info about this issue/pr!

@abhi12299
Copy link
Contributor

This is working fine. Did you do something else that I missed?

sr.mov

@SagarRajput-7
Copy link
Contributor

SagarRajput-7 commented Sep 22, 2024

@srikanthccv, @makeavish - Its working fine for me also, please check:

Screen.Recording.2024-09-22.at.6.58.05.PM.mov

But as for the understanding of what threshold should mean for the table panel, it is still unclear as here we have comparison operators like - > < >= <= which mostly doesn't make any sense when comparing a string value, like serviceName, etc.

@makeavish
Copy link
Member

@srikanthccv, @makeavish - Its working fine for me also, please check:

Screen.Recording.2024-09-22.at.6.58.05.PM.mov
But as for the understanding of what threshold should mean for the table panel, it is still unclear as here we have comparison operators like - > < >= <= which mostly doesn't make any sense when comparing a string value, like serviceName, etc.

Looks like it works now, we should only should show float/int columns in suggestions

@srikanthccv
Copy link
Member Author

@SagarRajput-7 please see Table panel where threshold doesn't work panel here https://stagingapp.signoz.io/dashboard/73d39077-bc3b-42ad-86c5-b3ed962af521?relativeTime=30m

@SagarRajput-7
Copy link
Contributor

Fixed under this - #6079

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants