Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create a network payload meter #495

Closed
wants to merge 1 commit into from

Conversation

shivanshuraj1333
Copy link
Member

@shivanshuraj1333 shivanshuraj1333 commented Dec 29, 2024

Adds some refactoring on top of #493 which makes it generic and also allows it to be used in the gateway code.

Provides a way for serialization, it could be json or proto
Provides a way to do decoding, it could be otlp (plain upstream marshaling), or signoz (deep marshaling used in billing)

Implements Meter for logs, metrics, traces.

On the new instances of logs, metrics, traces, Size and Count can directly be called without worrying about anything.

But still there are few concerns, since we are deciding to put the module in [signoz-otel-collector](https://github.com/SigNoz/signoz-otel-collector) I am facing below problems:

@shivanshuraj1333 shivanshuraj1333 force-pushed the feat/networkmeter branch 2 times, most recently from 9182b01 to 68c19db Compare December 29, 2024 14:00
@shivanshuraj1333 shivanshuraj1333 changed the title create a network payload meter feat: Create a network payload meter Dec 29, 2024
@grandwizard28
Copy link
Collaborator

Closing this as per discussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants