Skip to content

(for Mohammed or Gary) add new fields to the login event #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 11, 2019
Merged

(for Mohammed or Gary) add new fields to the login event #35

merged 1 commit into from
Jan 11, 2019

Conversation

@ChloeChi
Copy link
Contributor

@ChloeChi ChloeChi commented Jan 8, 2019 •
edited
Loading

Purpose:

  • Adde support for the new fields in the $login event

Technical overview:

  • update CHANGES.md, README.md, build.gradle
  • update LoginFieldSet.java to support the new fields
  • update test cases in LoginEventTest.java

Testing Plan:

  • passed uts locally

Deployment:
after the API event($login) is deployed:

  • will publish to Maven
  • Github release

Others:

@ChloeChi ChloeChi requested review from garylee1 and mjouahri January 8, 2019 22:47
@ChloeChi ChloeChi changed the title [WIP] add new fields to the login event (for Mohammed or Gary) add new fields to the login event Jan 10, 2019
mjouahri
mjouahri approved these changes Jan 11, 2019
View reviewed changes
Copy link
Contributor

@mjouahri mjouahri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well :)

@ChloeChi ChloeChi merged commit 4561b26 into master Jan 11, 2019
@ehrmann ehrmann deleted the cchi_update_login_event branch May 1, 2019 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@garylee1 garylee1 garylee1 approved these changes

@mjouahri mjouahri mjouahri approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ChloeChi @garylee1 @mjouahri