(For David) Add support for Rescore User and Get User Score APIs #30
Conversation
| .addPathSegment(userSoreFieldSet.getUserId()) | ||
| .addPathSegment("score") | ||
| .addQueryParameter("api_key", userSoreFieldSet.getApiKey()); | ||
| if (userSoreFieldSet.getAbuseTypes() != null && userSoreFieldSet.getAbuseTypes().size() > 0) { |
There was a problem hiding this comment.
nit: size() > 0 -> !isEmpty()
There was a problem hiding this comment.
Good catch. I should've looked more closely before copy pasting from ScoreRequest.java.
| if (userSoreFieldSet.getAbuseTypes() != null && userSoreFieldSet.getAbuseTypes().size() > 0) { | ||
| String queryParamVal = ""; | ||
| for (String abuseType : userSoreFieldSet.getAbuseTypes()) { | ||
| queryParamVal += (abuseType + ","); |
There was a problem hiding this comment.
This pattern is n^2 in Java. I'm working on removing Guava in another PR, so I'll move a join method into a util class.
| } | ||
|
|
||
| Decision o = (Decision) other; | ||
| return getId().equals(o.getId()) |
There was a problem hiding this comment.
These fields look nullable. Maybe use Objects.equals(getId(), o.getId())
There was a problem hiding this comment.
Switched to Objects.equals for all the string comparisons here.
atpaino
force-pushed
the
atpaino_add_support_get_user_score_rescore_user
branch
from
263a357 to
c026154
Compare
atpaino
force-pushed
the
atpaino_add_support_get_user_score_rescore_user
branch
from
c026154 to
46d5de2
Compare
| @Expose @SerializedName("score") private Double score; | ||
| @Expose @SerializedName("reasons") private List<Reason> reasons; | ||
| @Expose @SerializedName("status") private int status; | ||
| @Expose @SerializedName("error_message") private String error_message; |
There was a problem hiding this comment.
This should be camel case, along with the setters and getters
There was a problem hiding this comment.
Oh, whoops. Will fix.
|
|
||
| UserScoreRequest request = client.buildRequest(userScoreFieldSet); | ||
| EntityScoreResponse siftResponse = request.send(); | ||
|
|
|
|
||
| import java.util.List; | ||
|
|
||
| public class AbuseScoreV205 { |
There was a problem hiding this comment.
Broad question: do we really want to put V205 in this class name? It'd be the only class like that, and the library is already intended to be used for v205. I'd almost call it an EntityAbuseScore, but it's not really tied to entities. ExtendedAbuseScore?
There was a problem hiding this comment.
As discussed offline, I'm going to add these new fields to the existing AbuseScore instead of introducing a new AbuseScoreV205.
@ehrmann
Purpose
Adds support for the new GET|Post /v205/users/{userId}/score APIs to this client library.
Testing Plan