PR feedback

Author: atpaino

src/main/java/com/siftscience/UserScoreRequest.java

@@ -46,15 +46,16 @@ EntityScoreResponse buildResponse(Response response, FieldSet requestFields)
      */
     @Override
     protected HttpUrl path(HttpUrl baseUrl) {
-        UserScoreFieldSet userSoreFieldSet = (UserScoreFieldSet)fieldSet;
+        UserScoreFieldSet userScoreFieldSet = (UserScoreFieldSet)fieldSet;
         HttpUrl.Builder builder = baseUrl.newBuilder().addPathSegment("v205");
         builder.addPathSegment("users")
-                .addPathSegment(userSoreFieldSet.getUserId())
+                .addPathSegment(userScoreFieldSet.getUserId())
                 .addPathSegment("score")
-                .addQueryParameter("api_key", userSoreFieldSet.getApiKey());
-        if (userSoreFieldSet.getAbuseTypes() != null && userSoreFieldSet.getAbuseTypes().size() > 0) {
+                .addQueryParameter("api_key", userScoreFieldSet.getApiKey());
+        if (userScoreFieldSet.getAbuseTypes() != null
+                && !userScoreFieldSet.getAbuseTypes().isEmpty()) {
             String queryParamVal = "";
-            for (String abuseType : userSoreFieldSet.getAbuseTypes()) {
+            for (String abuseType : userScoreFieldSet.getAbuseTypes()) {
                 queryParamVal += (abuseType + ",");
             }
             builder.addQueryParameter("abuse_types",

src/main/java/com/siftscience/model/Decision.java

@@ -3,6 +3,8 @@
 import com.google.gson.annotations.Expose;
 import com.google.gson.annotations.SerializedName;
 
+import java.util.Objects;
+
 public class Decision {
     @Expose @SerializedName("id") private String id;
     @Expose @SerializedName("category") private String category;
@@ -62,10 +64,10 @@ public boolean equals(Object other) {
         }
 
         Decision o = (Decision) other;
-        return getId().equals(o.getId())
-                && getCategory().equals(o.getCategory())
+        return Objects.equals(getId(), o.getId())
+                && Objects.equals(getCategory(), o.getCategory())
                 && getTime() == o.getTime()
-                && getSource().equals(o.getSource())
-                && getDescription().equals(o.getDescription());
+                && Objects.equals(getSource(), o.getSource())
+                && Objects.equals(getDescription(), o.getDescription());
     }
 }