Merge pull request #2203 from Shopify/uk-consider-more-subconstants

Stop ignoring symbols in payload when discovering subconstants

Author: paracycle

Gemfile.lock

@@ -170,7 +170,7 @@ GEM
       pp (>= 0.6.0)
       rdoc (>= 4.0.0)
       reline (>= 0.4.2)
-    json (2.9.1)
+    json (2.10.1)
     json_api_client (1.23.0)
       activemodel (>= 6.0.0)
       activesupport (>= 6.0.0)

lib/tapioca/gem/listeners/subconstants.rb

@@ -14,11 +14,10 @@ class Subconstants < Base
         sig { override.params(event: ScopeNodeAdded).void }
         def on_scope(event)
           symbol = event.symbol
-          return if @pipeline.symbol_in_payload?(symbol) && event.node.empty?
+          constant = event.constant
 
           prefix = symbol == "Object" ? "" : symbol
 
-          constant = event.constant
           constants_of(constant).sort.uniq.map do |constant_name|
             name = "#{prefix}::#{constant_name}"
             subconstant = constantize(name)