add check to clear errors on first success if

error_threshold_timeout_enabled false

Author: abishanan-shopify

lib/semian/circuit_breaker.rb

@@ -77,6 +77,7 @@ def mark_failed(error)
     end
 
     def mark_success
+      @errors.clear unless error_threshold_timeout_enabled
       return unless half_open?
 
       @successes.increment

test/helpers/circuit_breaker_helper.rb

@@ -22,6 +22,7 @@ def trigger_error!(resource = @resource, error = SomeError)
 
   def assert_circuit_closed(resource = @resource)
     block_called = false
+
     resource.acquire { block_called = true }
 
     assert(block_called, "Expected the circuit to be closed, but it was open")