Skip to content

Commit d3ea389

Browse files
committed
Remove too platform sensitive assertions
1 parent 62493b5 commit d3ea389

File tree

1 file changed

+4
-32
lines changed

1 file changed

+4
-32
lines changed

spec/ruby/core/io/buffer/map_spec.rb

Lines changed: 4 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -89,24 +89,17 @@ def open_big_file_fixture
8989
end
9090

9191
context "with an empty file" do
92-
ruby_version_is ""..."4.0" do
93-
it "raises a SystemCallError" do
94-
@file = File.open("#{__dir__}/../fixtures/empty.txt", "r+")
95-
-> { IO::Buffer.map(@file) }.should raise_error(SystemCallError)
96-
end
97-
end
98-
9992
ruby_version_is "4.0" do
10093
it "raises ArgumentError" do
101-
@file = File.open("#{__dir__}/../fixtures/empty.txt", "r+")
94+
@file = File.open("#{__dir__}/../fixtures/empty.txt", "rb+")
10295
-> { IO::Buffer.map(@file) }.should raise_error(ArgumentError, "Invalid negative or zero file size!")
10396
end
10497
end
10598
end
10699

107100
context "with a file opened only for reading" do
108-
it "raises a SystemCallError if no flags are used" do
109-
@file = File.open("#{__dir__}/../fixtures/read_text.txt", "r")
101+
it "raises a SystemCallError unless read-only" do
102+
@file = File.open("#{__dir__}/../fixtures/read_text.txt", "rb")
110103
-> { IO::Buffer.map(@file) }.should raise_error(SystemCallError)
111104
end
112105
end
@@ -128,15 +121,6 @@ def open_big_file_fixture
128121
end
129122

130123
context "if size is 0" do
131-
ruby_version_is ""..."4.0" do
132-
platform_is_not :windows do
133-
it "raises a SystemCallError" do
134-
@file = open_fixture
135-
-> { IO::Buffer.map(@file, 0) }.should raise_error(SystemCallError)
136-
end
137-
end
138-
end
139-
140124
ruby_version_is "4.0" do
141125
it "raises ArgumentError" do
142126
@file = open_fixture
@@ -247,18 +231,6 @@ def open_big_file_fixture
247231
-> { IO::Buffer.map(@file, 4, nil) }.should raise_error(TypeError, /no implicit conversion/)
248232
end
249233

250-
it "raises a SystemCallError if offset is not an allowed value" do
251-
@file = open_fixture
252-
-> { IO::Buffer.map(@file, 4, 3) }.should raise_error(SystemCallError)
253-
end
254-
255-
ruby_version_is ""..."4.0" do
256-
it "raises a SystemCallError if offset is negative" do
257-
@file = open_fixture
258-
-> { IO::Buffer.map(@file, 4, -1) }.should raise_error(SystemCallError)
259-
end
260-
end
261-
262234
ruby_version_is "4.0" do
263235
it "raises ArgumentError if offset is negative" do
264236
@file = open_fixture
@@ -279,7 +251,7 @@ def open_big_file_fixture
279251
end
280252

281253
it "allows mapping read-only files" do
282-
@file = File.open("#{__dir__}/../fixtures/read_text.txt", "r")
254+
@file = File.open("#{__dir__}/../fixtures/read_text.txt", "rb")
283255
@buffer = IO::Buffer.map(@file, nil, 0, IO::Buffer::READONLY)
284256

285257
@buffer.should.readonly?

0 commit comments

Comments
 (0)