Make URI parsing more platform aware #3805
Open
+75
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
pkondzior
force-pushed
the
platform-related-uri-optimisations
branch
from
179b2b7 to
e87f701
Compare
vinistock
added
server
vinistock
reviewed
Nov 6, 2025
Comment on lines
+77
to
+78
| # we can bail out parsing if there is nothing to unescape | ||
| return parsed_path unless parsed_path.match?(/%[0-9A-Fa-f]{2}/) |
Member
There was a problem hiding this comment.
Why can we avoid unescaping here?
Comment on lines
+94
to
+95
| # we can bail out parsing if there is nothing to be unescaped | ||
| return unescaped_path unless unescaped_path.match?(/%[0-9A-Fa-f]{2}/) |
Member
There was a problem hiding this comment.
Same question, why does this not need to be escaped?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Related to #2660
Makes URI parsing and normalization platform-aware, by splitting code paths into separate methods.
Overall on macos this brings following speedups:
Implementation
from_win_path(Windows)from_unix_path(Unix)from_pathnow auto-selects based on platform.to_standardized_win_path(Windows)to_standardized_unix_path(Unix)to_standardized_pathnow auto-selects based on platform.UNSAFE_REGEX, previously it was always instantiated onfrom_pathmethod call//?/).from_path,to_standardized_path, andfull_pathsignatures.Automated Tests