Make srb happy

Author: pkondzior

lib/ruby_indexer/lib/ruby_indexer/entry.rb

@@ -24,6 +24,22 @@ def initialize(name, uri, location, comments)
       @comments = comments
       @visibility = :public #: Symbol
       @location = location
+      @file_path = @uri.full_path #: String?
+      @file_name = if @uri.scheme == "untitled"
+        @uri.opaque
+      else
+        File.basename(
+          @file_path, #: as !nil
+        )
+      end #: String?
+      @in_dependencies = if @file_path
+        ::RubyLsp::BUNDLE_PATH &&
+          @file_path.start_with?(
+            ::RubyLsp::BUNDLE_PATH, #: as !nil
+          ) || @file_path.start_with?(RbConfig::CONFIG["rubylibdir"])
+      else
+        false
+      end #: bool
     end
 
     #: -> bool
@@ -48,28 +64,17 @@ def resolved?
 
     #: -> bool
     def in_dependencies?
-      @in_dependencies ||= file_path && (
-        ::RubyLsp::BUNDLE_PATH && file_path.start_with?(
-          ::RubyLsp::BUNDLE_PATH, #: as !nil
-        ) ||
-        file_path.start_with?(RbConfig::CONFIG["rubylibdir"])
-      )
+      @in_dependencies
     end
 
-    #: -> String
+    #: -> String?
     def file_name
-      @file_name ||= if @uri.scheme == "untitled"
-        @uri.opaque #: as !nil
-      else
-        File.basename(
-          file_path, #: as !nil
-        )
-      end
+      @file_name
     end
 
     #: -> String?
     def file_path
-      @file_path ||= @uri.full_path
+      @file_path
     end
 
     #: -> String
@@ -389,7 +394,7 @@ def initialize(target, nesting, name, uri, location, comments) # rubocop:disable
         @nesting = nesting
       end
 
-      #: -> Bool
+      #: -> bool
       def resolved?
         false
       end
@@ -414,6 +419,7 @@ def initialize(target, unresolved_alias)
         @unresolved_alias = unresolved_alias
       end
 
+      #: -> String?
       def comments
         @comments ||= @unresolved_alias.comments
       end
@@ -465,7 +471,7 @@ def initialize(new_name, old_name, owner, uri, location, comments) # rubocop:dis
         @owner = owner
       end
 
-      #: -> Bool
+      #: -> bool
       def resolved?
         false
       end

lib/ruby_indexer/lib/ruby_indexer/index.rb

@@ -215,9 +215,7 @@ def fuzzy_search(query)
         [entries, -similarity] if similarity > ENTRY_SIMILARITY_THRESHOLD
       end
       results.sort_by!(&:last)
-      results.flat_map do |entries, _similarity|
-        skip_unresolved_entries(entries)
-      end
+      results.flat_map(&:first)
     end
 
     #: (String? name, String receiver_name) -> Array[(Entry::Member | Entry::MethodAlias)]
@@ -731,7 +729,7 @@ def entries_for(uri, type = nil)
       entries&.grep(type)
     end
 
-    #: -> voide
+    #: -> void
     def process_unresolved_entries
       @entries.values.each do |entries|
         entries.each do |entry|
@@ -1071,34 +1069,5 @@ def resolve_method_alias(entry, receiver_name, seen_names)
       original_entries << resolved_alias
       resolved_alias
     end
-
-    # Attempts to resolve an entry if it is an unresolved constant or method alias.
-    # Returns the resolved entry, or nil if it cannot be resolved.
-    #: (Entry) -> Entry?
-    def resolve_entry(entry)
-      case entry
-      when Entry::UnresolvedConstantAlias
-        resolved_entry = resolve_alias(entry, [])
-        resolved_entry unless resolved_entry.is_a?(Entry::UnresolvedConstantAlias)
-      when Entry::UnresolvedMethodAlias
-        resolved_entry = resolve_method_alias(entry, entry.owner&.name || "", [])
-        resolved_entry unless resolved_entry.is_a?(Entry::UnresolvedMethodAlias)
-      else
-        entry
-      end
-    end
-
-    # Filters and resolves entries, skipping those that remain unresolved.
-    # Returns an array of successfully resolved entries.
-    #: (Array[Entry]) -> Array[Entry?]
-    def skip_unresolved_entries(entries)
-      entries.filter_map do |entry|
-        resolved_entry = resolve_entry(entry)
-
-        next unless resolved_entry
-
-        resolved_entry
-      end
-    end
   end
 end

lib/ruby_indexer/lib/ruby_indexer/uri.rb

@@ -52,11 +52,7 @@ def from_unix_path(path:, fragment: nil, scheme: "file", load_path_entry: nil)
         uri
       end
 
-      if Gem.win_platform?
-        alias_method :from_path, :from_win_path
-      else
-        alias_method :from_path, :from_unix_path
-      end
+      alias_method :from_path, Gem.win_platform? ? :from_windows_path : :from_unix_path
     end
 
     #: String?
@@ -70,6 +66,7 @@ def add_require_path_from_load_entry(load_path_entry)
       self.require_path = path.delete_prefix("#{load_path_entry}/").delete_suffix(".rb")
     end
 
+    #: -> String?
     # On Windows, when we're getting the file system path back from the URI, we need to remove the leading forward
     # slash
     def to_standardized_win_path
@@ -100,13 +97,7 @@ def to_standardized_unix_path
       PARSER.unescape(unscapped_path)
     end
 
-
-    if Gem.win_platform?
-      alias_method :to_standardized_path, :to_standardized_win_path
-    else
-      alias_method :to_standardized_path, :to_standardized_unix_path
-    end
-
-    alias_method :full_path, :to_standardized_path
+    alias_method :to_standardized_path, Gem.win_platform? ? :to_standardized_win_path : :to_standardized_unix_path
+    alias_method :full_path, Gem.win_platform? ? :to_standardized_win_path : :to_standardized_unix_path
   end
 end

sorbet/rbi/shims/uri.rbi

@@ -5,6 +5,24 @@ module URI
 
   class Generic
     PARSER = T.let(const_defined?(:RFC2396_PARSER) ? RFC2396_PARSER : DEFAULT_PARSER, RFC2396_Parser)
+
+   class << self
+      sig do
+        params(
+          path: String,
+          fragment: T.nilable(String),
+          scheme: String,
+          load_path_entry: T.nilable(String)
+        ).returns(URI::Generic)
+      end
+      def from_path(path:, fragment: nil, scheme: "file", load_path_entry: nil); end
+    end
+
+    sig { returns(T.nilable(String)) }
+    def to_standardized_path; end
+
+    sig { returns(T.nilable(String)) }
+    def full_path; end
   end
 
   class File