Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⭐️ Fix and refactorize antialiasing defaults #430

Merged
merged 3 commits into from
Apr 27, 2022
Merged

Conversation

wcandillon
Copy link
Contributor

@wcandillon wcandillon commented Apr 25, 2022

This PR fixes the antialiasing default for the Paint component.
The issue came up when writing the following:

<Circle color="blue" r={9} cx={9} cy={9}> 
  <Paint style="stroke" color="white" strokeWidth={2} />
</Circle>

Suddenly the edges of the circle wouldn't be anti-aliased anymore.
I took advantage of this fix, to factorize the Skia paint default settings, add an antiAlias property for paints, and fix dead anchors in the documentation.

@wcandillon wcandillon self-assigned this Apr 25, 2022
@wcandillon wcandillon changed the title Fix and refactorize antialiasing defaults ⭐️ Fix and refactorize antialiasing defaults Apr 25, 2022
Copy link
Contributor

@chrfalch chrfalch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wcandillon wcandillon merged commit 4f5301d into main Apr 27, 2022
@wcandillon wcandillon deleted the fix/antialiasing branch May 22, 2022 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants