[polaris.shopify.com] Fix next.js rehydration issue #7922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martenbjork
added
the
🤖Skip Changelog
martenbjork
changed the title
kyledurand
approved these changes
Dec 15, 2022
Member
kyledurand
left a comment
kyledurand
left a comment
There was a problem hiding this comment.
Looks good, didn't tophat but put some recommendations on a11y improvements
| {isMounted && ( | ||
| <button className={styles.DarkModeToggle} onClick={darkMode.toggle}> | ||
| {darkMode.value ? ( | ||
| <span className={styles.LightModeIcon}>💡</span> |
Member
There was a problem hiding this comment.
Suggested change
| <span className={styles.LightModeIcon}>💡</span> | |
| <span className={styles.LightModeIcon} role="img" aria-label="toggle light mode">💡</span> |
| {darkMode.value ? ( | ||
| <span className={styles.LightModeIcon}>💡</span> | ||
| ) : ( | ||
| <span className={styles.DarkModeIcon}>🌙</span> |
Member
There was a problem hiding this comment.
Suggested change
| <span className={styles.DarkModeIcon}>🌙</span> | |
| <span className={styles.DarkModeIcon} role="img" aria-label="toggle dark mode">🌙</span> |
laurkim
approved these changes
Dec 15, 2022
Contributor
Author
Sweet! Thanks, Lo! 🚀 |
Merged
juzser
pushed a commit
to juzser/polaris
that referenced
this pull request
Jul 27, 2023
Fixes this annoying message in development: <img width="1011" alt="image" src="https://user-images.githubusercontent.com/875708/207904298-8ebb19c3-3b9d-43cf-8a1a-78939a3f6b1a.png"> It was caused by the dark mode switcher having different states between the server and the client, thus breaking rehydration. This fix ensures that the dark mode toggle is only rendered on the client.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this annoying message in development:
It was caused by the dark mode switcher having different states between the server and the client, thus breaking rehydration. This fix ensures that the dark mode toggle is only rendered on the client.