Skip to content

Commit d627fee

Browse files
authored
Update Spinner (#9345)
### WHY are these changes introduced? Resolves https://github.com/Shopify/polaris-summer-editions/issues/72 ### WHAT is this pull request doing? - Updates the Spinner `fill` color ### How to 🎩 Review on [Storybook](https://5d559397bae39100201eedc1-pyvdrbupij.chromatic.com/?path=/story/all-components-spinner--all) - Ensure beta flagged Spinner styles render as expected - Ensure no regressions to the existing Spinner styles
1 parent 78e0326 commit d627fee

File tree

2 files changed

+16
-0
lines changed

2 files changed

+16
-0
lines changed

polaris-react/src/components/Spinner/Spinner.scss

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
@import '../../styles/common';
2+
13
$small-size: 20px;
24
$large-size: 44px;
35

@@ -10,6 +12,10 @@ $large-size: 44px;
1012
animation: var(--p-motion-keyframes-spin) var(--p-motion-duration-500) linear
1113
infinite;
1214
fill: var(--p-color-border-info);
15+
16+
#{$se23} & {
17+
fill: var(--p-color-bg-interactive);
18+
}
1319
}
1420

1521
.sizeSmall svg {

polaris-react/src/components/Spinner/Spinner.stories.tsx

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,16 @@ export default {
1414
component: Spinner,
1515
} as ComponentMeta<typeof Spinner>;
1616

17+
export function All() {
18+
return (
19+
<>
20+
<Default />
21+
<Small />
22+
<WithFocusManagement />
23+
</>
24+
);
25+
}
26+
1727
export function Default() {
1828
return <Spinner accessibilityLabel="Spinner example" size="large" />;
1929
}

0 commit comments

Comments
 (0)