Skip to content

Commit d2d396f

Browse files
authored
[Collapsible] Remove deprecated Collapsible argument (#7397)
### WHY are these changes introduced? Removes a deprecated argument on the Collapsible component with the major version bump. ### WHAT is this pull request doing? Removes the prop as a breaking change. ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) N/A tophatting instructions as Polaris does not use this prop internally. ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
1 parent e8cc97c commit d2d396f

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

.changeset/stupid-vans-kick.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@shopify/polaris': major
3+
---
4+
5+
Removed deprecated preventMeasuringOnChildUpdate prop on Collapsible

polaris-react/src/components/Collapsible/Collapsible.tsx

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,6 @@ export interface CollapsibleProps {
2222
* @default transition={{duration: 'var(--p-duration-150)', timingFunction: 'var(--p-ease-in-out)'}}
2323
*/
2424
transition?: boolean | Transition;
25-
/** @deprecated Re-measuring is no longer necessary on children update **/
26-
preventMeasuringOnChildrenUpdate?: boolean;
2725
/** The content to display inside the collapsible. */
2826
children?: React.ReactNode;
2927
}
@@ -35,7 +33,6 @@ export function Collapsible({
3533
expandOnPrint,
3634
open,
3735
transition = true,
38-
preventMeasuringOnChildrenUpdate: _preventMeasuringOnChildrenUpdate,
3936
children,
4037
}: CollapsibleProps) {
4138
const [height, setHeight] = useState(0);

0 commit comments

Comments
 (0)