Revert "[Breadcrumbs] Allow breadcrumbs to be singular (#8016)"

This reverts commit ca77f0b.

Author: itwasmattgregg

polaris-react/src/components/Breadcrumbs/Breadcrumbs.tsx

@@ -11,13 +11,11 @@ import styles from './Breadcrumbs.scss';
 
 export interface BreadcrumbsProps {
   /** Collection of breadcrumbs */
-  breadcrumbs: (CallbackAction | LinkAction) | (CallbackAction | LinkAction)[];
+  breadcrumbs: (CallbackAction | LinkAction)[];
 }
 
 export function Breadcrumbs({breadcrumbs}: BreadcrumbsProps) {
-  const breadcrumb = Array.isArray(breadcrumbs)
-    ? breadcrumbs[breadcrumbs.length - 1]
-    : breadcrumbs;
+  const breadcrumb = breadcrumbs[breadcrumbs.length - 1];
   if (breadcrumb == null) {
     return null;
   }

polaris-react/src/components/Breadcrumbs/tests/Breadcrumbs.test.tsx

@@ -109,16 +109,6 @@ describe('<Breadcrumbs />', () => {
     });
   });
 
-  it('renders when not passed an array', () => {
-    const breadcrumb: LinkAction = {
-      content: 'Products',
-      url: 'https://www.shopify.com',
-    };
-    const wrapper = mountWithApp(<Breadcrumbs breadcrumbs={breadcrumb} />);
-
-    expect(wrapper.html()).not.toBe('');
-  });
-
   it('renders nothing when empty', () => {
     const wrapper = mountWithApp(<Breadcrumbs breadcrumbs={[]} />);
 

polaris-react/src/components/Page/Page.tsx

@@ -40,10 +40,7 @@ export function Page({
         rest.secondaryActions.length > 0) ||
         isReactElement(rest.secondaryActions))) ||
     (rest.actionGroups != null && rest.actionGroups.length > 0) ||
-    (rest.breadcrumbs != null &&
-      Array.isArray(rest.breadcrumbs) &&
-      rest.breadcrumbs.length > 0) ||
-    rest.breadcrumbs != null;
+    (rest.breadcrumbs != null && rest.breadcrumbs.length > 0);
 
   const contentClassName = classNames(
     !hasHeaderContent && styles.Content,

polaris-react/src/components/Page/components/Header/Header.tsx

@@ -74,7 +74,7 @@ export function Header({
   primaryAction,
   pagination,
   additionalNavigation,
-  breadcrumbs,
+  breadcrumbs = [],
   secondaryActions = [],
   actionGroups = [],
   compactTitle = false,
@@ -98,8 +98,7 @@ export function Header({
     !actionGroups.length;
 
   const breadcrumbMarkup =
-    (Array.isArray(breadcrumbs) && breadcrumbs.length > 0) ||
-    (!Array.isArray(breadcrumbs) && breadcrumbs) ? (
+    breadcrumbs.length > 0 ? (
       <div className={styles.BreadcrumbWrapper}>
         <Breadcrumbs breadcrumbs={breadcrumbs} />
       </div>
@@ -179,7 +178,7 @@ export function Header({
     navigationMarkup && styles.hasNavigation,
     actionMenuMarkup && styles.hasActionMenu,
     isNavigationCollapsed && styles.mobileView,
-    !breadcrumbMarkup && styles.noBreadcrumbs,
+    !breadcrumbs.length && styles.noBreadcrumbs,
     title && title.length < LONG_TITLE && styles.mediumTitle,
     title && title.length > LONG_TITLE && styles.longTitle,
   );

polaris-react/src/components/Page/components/Header/tests/Header.test.tsx

@@ -62,24 +62,6 @@ describe('<Header />', () => {
         breadcrumbs,
       });
     });
-
-    it('renders breadcrumb markup if not an array', () => {
-      const breadcrumb: LinkAction = {
-        content: 'Products',
-        url: 'https://www.google.com',
-      };
-      const header = mountWithApp(
-        <Header {...mockProps} breadcrumbs={breadcrumb} />,
-      );
-      expect(header).toContainReactComponent(Breadcrumbs, {
-        breadcrumbs: breadcrumb,
-      });
-    });
-
-    it('does not render breadcrumb markup if no breadcrumbs', () => {
-      const header = mountWithApp(<Header {...mockProps} />);
-      expect(header).not.toContainReactComponent(Breadcrumbs);
-    });
   });
 
   describe('primaryAction', () => {

polaris-react/src/components/Page/tests/Page.test.tsx

@@ -248,17 +248,6 @@ describe('<Page />', () => {
       expect(page).toContainReactComponent(Header);
     });
 
-    it('renders a <Header /> when defined not as an array', () => {
-      const breadcrumbs = {
-        content: 'Products',
-        onAction: noop,
-      };
-      const page = mountWithApp(
-        <Page {...mockProps} breadcrumbs={breadcrumbs} />,
-      );
-      expect(page).toContainReactComponent(Header);
-    });
-
     it('gets passed into the <Header />', () => {
       const page = mountWithApp(
         <Page {...mockProps} breadcrumbs={breadcrumbs} />,