Skip to content

Commit 764f17d

Browse files
authored
Add back needless disables to all stylelint comments (#8657)
### WHY are these changes introduced? `// stylelint-disable` is overloading scss code and not doing anything many times ### WHAT is this pull request doing? Stop shipping comments that do nothing or accidentally leave them around.
1 parent 62b7123 commit 764f17d

File tree

2 files changed

+6
-9
lines changed

2 files changed

+6
-9
lines changed

.changeset/fast-glasses-rhyme.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@shopify/stylelint-polaris': major
3+
---
4+
5+
Turn on reportNeedlessDisables for all comments

stylelint-polaris/index.js

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -504,15 +504,7 @@ const stylelintPolarisCoverageOptions = {
504504
module.exports = {
505505
customSyntax: 'postcss-scss',
506506
reportDescriptionlessDisables: true,
507-
reportNeedlessDisables: [
508-
true,
509-
{
510-
// Report needless disables for all rules except layout coverage rules
511-
// Note: This doesn't affect the default Stylelint behavior/reporting
512-
// and is only need because we dynamically create these rule names
513-
except: ['all', /^polaris\/layout\/.+$/],
514-
},
515-
],
507+
reportNeedlessDisables: true,
516508
reportInvalidScopeDisables: [
517509
true,
518510
{

0 commit comments

Comments
 (0)