Skip to content

Commit 6114e2f

Browse files
Yuraima Estevezkyledurand
authored andcommitted
started updating styling
1 parent 35f7a8b commit 6114e2f

File tree

2 files changed

+13
-4
lines changed

2 files changed

+13
-4
lines changed

polaris-react/src/components/Tag/Tag.scss

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,10 @@ $button-size: 20px;
99
align-items: center;
1010
min-height: 28px;
1111
padding: 0 var(--p-space-2);
12+
// TODO which secondary bg color? new or existing?
1213
background-color: var(--p-color-bg-strong);
13-
border-radius: var(--p-border-radius-1);
14+
border-radius: var(--p-border-radius-2);
15+
// TODO need secondary-text-on-fill color token
1416
color: var(--p-color-text);
1517

1618
&.disabled {
@@ -35,7 +37,10 @@ $button-size: 20px;
3537
line-height: var(--p-font-line-height-2);
3638

3739
&:hover {
40+
// TODO need subdued-fill token
3841
background: var(--p-color-bg-strong-hover);
42+
// TODO need secondary-border-l2
43+
// border-color: var(--p-color-secondary-border-l2)
3944
}
4045

4146
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
@@ -48,7 +53,10 @@ $button-size: 20px;
4853
}
4954

5055
&:active {
56+
// TODO need secondary-fill-l2
5157
background: var(--p-color-bg-strong-hover);
58+
// TODO need secondary-border-l2
59+
// border-color: var(--p-secondary-borderl2);
5260
}
5361

5462
&:disabled {
@@ -78,16 +86,16 @@ $button-size: 20px;
7886
}
7987

8088
.TagText {
81-
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
82-
font-size: 13px;
8389
line-height: var(--p-font-line-height-2);
8490
min-height: $height;
8591
padding: var(--p-space-1) 0;
8692
overflow: hidden;
8793
text-overflow: ellipsis;
8894
white-space: nowrap;
8995
vertical-align: middle;
96+
// TODO need font-weight 450 token
9097

98+
// TODO check if we need sm viewport up styling
9199
@media #{$p-breakpoints-sm-up} {
92100
font-size: var(--p-font-size-75);
93101
padding: var(--p-space-05) 0;
@@ -102,7 +110,7 @@ $button-size: 20px;
102110
height: $button-size;
103111
width: $button-size;
104112
margin: 0 var(--p-space-1);
105-
border-radius: var(--p-border-radius-full);
113+
border-radius: var(--p-border-radius-2);
106114

107115
svg {
108116
fill: var(--p-color-icon);

polaris-react/src/components/Tag/Tag.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,7 @@ export function Tag({
8181
onMouseUp={handleMouseUpByBlurring}
8282
disabled={disabled}
8383
>
84+
{/* TODO update to new x icon */}
8485
<Icon source={CancelSmallMinor} />
8586
</button>
8687
) : null;

0 commit comments

Comments
 (0)