Skip to content

Commit 3e7e083

Browse files
authored
[General] Remove comments after cleanup (#8659)
### WHY are these changes introduced? After #8657 merged, there still seems to be some comments that are falling foul of the rules, causing the linter stage to fail. This PR just removes those offending comments. ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [x] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [x] Updated the component's `README.md` with documentation changes - [x] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
1 parent e3e2496 commit 3e7e083

File tree

4 files changed

+5
-22
lines changed

4 files changed

+5
-22
lines changed

.changeset/red-clocks-battle.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@shopify/polaris': patch
3+
---
4+
5+
Removed comments after stylelint rule changes that are breaking the rules

polaris-react/src/components/Navigation/Navigation.scss

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,6 @@ $disabled-fade: 0.6;
166166
.Badge {
167167
margin-left: var(--p-space-2);
168168
display: inline-flex;
169-
// stylelint-disable-next-line -- ensures badges are the same height as the text
170169
height: var(--p-font-line-height-2);
171170
margin-top: calc(var(--p-space-2) + var(--p-space-05));
172171
margin-right: var(--p-space-4);
@@ -214,7 +213,6 @@ $disabled-fade: 0.6;
214213
}
215214

216215
.ItemInnerWrapper {
217-
// stylelint-disable-next-line -- required for absolute positioning of actions
218216
position: relative;
219217
display: flex;
220218
flex-wrap: nowrap;
@@ -255,25 +253,20 @@ $disabled-fade: 0.6;
255253
}
256254

257255
.SecondaryActions {
258-
// stylelint-disable-next-line -- horizontal action icons layout
259256
display: flex;
260-
// stylelint-disable-next-line -- ensures correct height of actions
261257
height: nav(mobile-height);
262258

263259
&:last-child {
264260
margin-right: calc(var(--p-space-2) + var(--p-space-05));
265261
}
266262

267263
@media #{$p-breakpoints-md-up} {
268-
// stylelint-disable-next-line -- ensures correct height of actions
269264
height: nav(desktop-height);
270265
}
271266
}
272267

273268
.ItemWithFloatingActions {
274-
// stylelint-disable-next-line -- required for absolute positioning of actions
275269
position: relative;
276-
// stylelint-disable-next-line -- position actions to to the right of label
277270
display: flex;
278271
flex-wrap: nowrap;
279272

@@ -285,11 +278,8 @@ $disabled-fade: 0.6;
285278
.ItemInnerWrapper-display-actions-on-hover {
286279
@media #{$p-breakpoints-md-up} {
287280
.SecondaryActions {
288-
// stylelint-disable-next-line -- position floating actions at top right
289281
position: absolute;
290-
// stylelint-disable-next-line -- position floating actions at top right
291282
top: 0;
292-
// stylelint-disable-next-line -- position floating actions at top right
293283
right: 0;
294284
background: var(--p-background-hovered);
295285
visibility: hidden;
@@ -300,15 +290,10 @@ $disabled-fade: 0.6;
300290
&::before {
301291
content: '';
302292
pointer-events: none;
303-
// stylelint-disable-next-line -- required for fade effect
304293
position: absolute;
305-
// stylelint-disable-next-line -- required for fade effect
306294
right: 100%;
307-
// stylelint-disable-next-line -- required for fade effect
308295
display: block;
309-
// stylelint-disable-next-line -- required for fade effect
310296
height: 100%;
311-
// stylelint-disable-next-line -- required for fade effect
312297
width: var(--p-space-8);
313298
// stylelint-disable-next-line -- required for fade effect
314299
background: linear-gradient(

polaris-react/src/components/Tooltip/Tooltip.scss

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
.TooltipContainer {
2-
// stylelint-disable-next-line -- The rule "property-disallowed-list" is not applicable since there does not exist a layout component that only sets the display property
32
display: flex;
43
}
54

polaris-react/src/components/Tooltip/components/TooltipOverlay/TooltipOverlay.scss

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,17 +21,13 @@
2121

2222
&::after {
2323
content: '';
24-
// stylelint-disable-next-line -- No Polaris layout component offers this
2524
position: absolute;
26-
// stylelint-disable-next-line -- No Polaris layout component offers this
2725
top: calc(var(--p-space-4) * -1);
2826
// stylelint-disable-next-line -- No Polaris layout component offers this
2927
left: calc(
3028
var(--pc-tooltip-chevron-x-pos) - var(--p-space-2) - var(--p-space-4)
3129
);
32-
// stylelint-disable-next-line -- No Polaris layout component offers this
3330
height: 0;
34-
// stylelint-disable-next-line -- No Polaris layout component offers this
3531
width: 0;
3632
border-width: var(--p-space-2);
3733
border-style: solid;
@@ -40,9 +36,7 @@
4036

4137
&.positionedAbove {
4238
&::after {
43-
// stylelint-disable-next-line -- No Polaris layout component offers this
4439
top: auto;
45-
// stylelint-disable-next-line -- No Polaris layout component offers this
4640
bottom: calc(var(--p-space-4) * -1);
4741
border-color: var(--p-surface) transparent transparent transparent;
4842
}

0 commit comments

Comments
 (0)