Adjust NodeJS versions so we support LTS 16/18 and future versions (#8211)

Co-Authored-By: Ben Scott <227292+BPScott@users.noreply.github.com>

Author: alex-page

.github/CONTRIBUTING.md

@@ -137,7 +137,7 @@ Each contributor is required to [sign a CLA](https://cla.shopify.com/). This pro
 
 ### Contribution prerequisites
 
-- You have Node installed at v18.13.0+ and Yarn at v1.22.18+
+- You have Node installed at v18.12.0+ and Yarn at v1.22.18+
 
 ### Best practices
 

.github/workflows/changelog.yml

@@ -21,10 +21,10 @@ jobs:
         with:
           fetch-depth: 0
 
-      - name: Setup Node with v18.13.0
+      - name: Setup Node with v18.12.0
         uses: actions/setup-node@v3
         with:
-          node-version: 18.13.0
+          node-version: 18.12.0
 
       - name: Check for Changeset
         run: npx @changesets/cli status --since="origin/main"

.github/workflows/ci-a11y-vrt.yml

@@ -32,10 +32,10 @@ jobs:
           sudo rm -rf "/usr/local/share/boost"
           sudo rm -rf "$AGENT_TOOLSDIRECTORY"
 
-      - name: Setup Node with v18.13.0
+      - name: Setup Node with v18.12.0
         uses: actions/setup-node@v3
         with:
-          node-version: 18.13.0
+          node-version: 18.12.0
           cache: yarn
 
       - name: Restore cache
@@ -72,10 +72,10 @@ jobs:
         with:
           fetch-depth: 0 # Chromatic git history to track changes
 
-      - name: Setup Node with v18.13.0
+      - name: Setup Node with v18.12.0
         uses: actions/setup-node@v3
         with:
-          node-version: 18.13.0
+          node-version: 18.12.0
           cache: yarn
 
       - name: Restore cache

.github/workflows/ci.yml

@@ -13,7 +13,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: ['16.16.0', '18.13.0']
+        node-version: ['16.13.0', '18.12.0']
     steps:
       - name: Checkout branch
         uses: actions/checkout@v3

.nvmrc

@@ -1 +1 @@
-v18.13.0
+v18.12.0

dev.yml

@@ -2,7 +2,7 @@ name: polaris
 up:
   - node:
       yarn: v1.22.18
-      version: v18.13.0 # to be kept in sync with .nvmrc and .github/workflows/ci.yml
+      version: v18.12.0 # to be kept in sync with .nvmrc and .github/workflows/ci.yml
   - custom:
       name: Build monorepo
       met?: yarn build --output-logs=none

documentation/Nodejs support.md

@@ -16,40 +16,40 @@ The `package.json` engines. This should match the `.github/workflows/ci.yml` and
 
 ```json
 "engines": {
-  "node": "^16.16.0 || ^18.13.0"
+  "node": "^16.13.0 || >=18.12.0"
 },
 ```
 
 The GitHub actions `.github/workflows/ci.yml` file. This should match the `package.json` and list all supported versions.
 
 ```yml
-node-version: ['16.16.0', '18.13.0']
+node-version: ['16.13.0', '18.12.0']
 ```
 
 The `dev.yml` file which creates a local development environment. This should match the `.nvmrc` file.
 
 ```yml
-version: v18.13.0
+version: v18.12.0
 ```
 
 The `.nvmrc` file for local development. This should match the `dev.yml` file.
 
 ```
-v18.13.0
+v18.12.0
 ```
 
 The `shipit.yml` files. This should point towards the GitHub Actions the packages require to pass before publishing.
 
 ```yml
 ci:
   require:
-    - 'Validate with Node v16.16.0'
-    - 'Validate with Node v18.13.0'
+    - 'Validate with Node v16.13.0'
+    - 'Validate with Node v18.12.0'
 
 merge:
   require:
-    - 'Validate with Node v16.16.0'
-    - 'Validate with Node v18.13.0'
+    - 'Validate with Node v16.13.0'
+    - 'Validate with Node v18.12.0'
 ```
 
 The `rollup.config.mjs` for some monorepo packages. This should match the minimum supported version.

package.json

@@ -3,7 +3,7 @@
   "version": "0.0.0",
   "private": true,
   "engines": {
-    "node": "^16.16.0 || ^18.13.0"
+    "node": "^16.13.0 || >=18.12.0"
   },
   "workspaces": {
     "packages": [

polaris-cli/package.json

@@ -31,7 +31,7 @@
   },
   "engine-strict": true,
   "engines": {
-    "node": "^16.16.0 || ^18.13.0"
+    "node": "^16.13.0 || >=18.12.0"
   },
   "os": [
     "darwin",

polaris-for-vscode/package.json

@@ -20,7 +20,8 @@
     "shopify"
   ],
   "engines": {
-    "node": "^16.16.0 || ^18.13.0"
+    "vscode": "^1.64.0",
+    "node": "^16.13.0 || >=18.12.0"
   },
   "categories": [
     "Other"