diff --git a/.changeset/flat-melons-design.md b/.changeset/flat-melons-design.md new file mode 100644 index 0000000000..c16145b26b --- /dev/null +++ b/.changeset/flat-melons-design.md @@ -0,0 +1,5 @@ +--- +'@shopify/cli-hydrogen': patch +--- + +Allow passing `customLogger` in `vite.config.js`. diff --git a/packages/cli/src/commands/hydrogen/dev.ts b/packages/cli/src/commands/hydrogen/dev.ts index a47f843d6f..f2050bfc99 100644 --- a/packages/cli/src/commands/hydrogen/dev.ts +++ b/packages/cli/src/commands/hydrogen/dev.ts @@ -221,22 +221,20 @@ export async function runDev({ await removeFile(joinPath(root, 'node_modules/.vite')); } - const customLogger = vite.createLogger(); - if (process.env.SHOPIFY_UNIT_TEST) { - // Make logs from Vite visible in tests - customLogger.info = (msg) => collectLog('info', msg); - customLogger.warn = (msg) => collectLog('warn', msg); - customLogger.error = (msg) => collectLog('error', msg); - } - const formatOptionsPromise = Promise.resolve().then(() => getCodeFormatOptions(root), ); const viteServer = await vite.createServer({ root, - customLogger, clearScreen: false, + customLogger: process.env.SHOPIFY_UNIT_TEST + ? Object.assign(vite.createLogger(), { + info: (msg: string) => collectLog('info', msg), + warn: (msg: string) => collectLog('warn', msg), + error: (msg: string) => collectLog('error', msg), + }) + : undefined, server: { host: host ? true : undefined, // Allow Vite to read files from the Hydrogen packages in local development.