-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relative relayouting #1192
Open
irisjae
wants to merge
18
commits into
Shopify:main
Choose a base branch
from
irisjae:master
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Relative relayouting #1192
+20,424
−8,407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested, it's working fine. It's not choppy when scrolling up. |
This was referenced May 25, 2024
@naqvitalha this PR looks to address a major issue for the library. Any chance of it getting reviewed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the list enters a region with bad size estimates, scrolling becomes incredibly choppy, appearing to the user as if the list content is jumping around as the user scrolls.
Another issue is that the list is not able to maintain the visible content position when the provided data changes.
This patch implements a relative relayouting algorithm both in native and in RecyclerListView, and solves these problems. Here is a longer analysis of the problem and solution.
Hopefully, this mechanism can be part of FlashList.
Relevant issues:
Relevant PRs:
experimentalScrollPositionManagement
support to FlashList #824Reviewers’ hat-rack 🎩
Screenshots or videos (if needed)
Checklist