Skip to content

Commit ff3f4e0

Browse files
elanalynnalfonso-noriega
authored andcommitted
Update hosted app identifier
1 parent 5dec2ef commit ff3f4e0

File tree

5 files changed

+8
-7
lines changed

5 files changed

+8
-7
lines changed

packages/app/src/cli/models/extensions/extension-instance.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -370,7 +370,7 @@ export class ExtensionInstance<TConfiguration extends BaseConfigType = BaseConfi
370370
this.specification.buildConfig.filePatterns,
371371
this.specification.buildConfig.ignoredFilePatterns,
372372
)
373-
case 'static_app':
373+
case 'hosted_app_home':
374374
await this.copyStaticAssets()
375375
break
376376
case 'none':

packages/app/src/cli/models/extensions/specification.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ export interface BuildAsset {
5555
}
5656

5757
type BuildConfig =
58-
| {mode: 'ui' | 'theme' | 'function' | 'tax_calculation' | 'none' | 'static_app'}
58+
| {mode: 'ui' | 'theme' | 'function' | 'tax_calculation' | 'none' | 'hosted_app_home'}
5959
| {mode: 'copy_files'; filePatterns: string[]; ignoredFilePatterns?: string[]}
6060
/**
6161
* Extension specification with all the needed properties and methods to load an extension.

packages/app/src/cli/models/extensions/specifications/app_config_hosted_app_home.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -89,14 +89,14 @@ describe('hosted_app_home', () => {
8989
})
9090

9191
describe('buildConfig', () => {
92-
test('should have static_app build mode', () => {
93-
expect(spec.buildConfig).toEqual({mode: 'static_app'})
92+
test('should have hosted_app_home build mode', () => {
93+
expect(spec.buildConfig).toEqual({mode: 'hosted_app_home'})
9494
})
9595
})
9696

9797
describe('identifier', () => {
9898
test('should have correct identifier', () => {
99-
expect(spec.identifier).toBe('hosted_app')
99+
expect(spec.identifier).toBe('hosted_app_home')
100100
})
101101
})
102102
})

packages/app/src/cli/models/extensions/specifications/app_config_hosted_app_home.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,11 @@ const HostedAppHomeTransformConfig: TransformationConfig = {
1212
static_root: 'static_root',
1313
}
1414

15-
export const HostedAppHomeSpecIdentifier = 'hosted_app'
15+
export const HostedAppHomeSpecIdentifier = 'hosted_app_home'
1616

1717
const hostedAppHomeSpec = createConfigExtensionSpecification({
1818
identifier: HostedAppHomeSpecIdentifier,
19-
buildConfig: {mode: 'static_app'} as const,
19+
buildConfig: {mode: 'hosted_app_home'} as const,
2020
schema: HostedAppHomeSchema,
2121
transformConfig: HostedAppHomeTransformConfig,
2222
copyStaticAssets: async (config, directory, outputPath) => {

packages/app/src/cli/services/generate/fetch-extension-specifications.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,7 @@ async function mergeLocalAndRemoteSpecs(
7878

7979
const merged = {...localSpec, ...remoteSpec, loadedRemoteSpecs: true} as RemoteAwareExtensionSpecification &
8080
FlattenedRemoteSpecification
81+
8182
// If configuration is inside an app.toml -- i.e. single UID mode -- we must be able to parse a partial slice.
8283
let handleInvalidAdditionalProperties: HandleInvalidAdditionalProperties
8384
switch (merged.uidStrategy) {

0 commit comments

Comments
 (0)