Allow CLI::UI.ask to work without a question parameter #594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes the `question` parameter optional in `CLI::UI.ask` and `CLI::UI::Prompt.ask` methods, allowing for simpler prompts when the question isn't needed.
RRethy
force-pushed
the
allow-no-question-for-ask
branch
from
d4ffea6 to
12b43b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
questionparameter optional inCLI::UI.askandCLI::UI::Prompt.askmethodsI want to be able to use cli-ui to repeatedly query the user for input. Since there isn't really a question, I'm looking to avoid having the question and the
?used on the preceding line each time.