Skip to content

Commit 10d895f

Browse files
authored
Merge pull request #202 from Shopify/rwstauner/redis-port
Enable running the ruby tests with alternate redis host/port
2 parents aa16b87 + bab916b commit 10d895f

File tree

9 files changed

+9
-9
lines changed

9 files changed

+9
-9
lines changed

ruby/dev.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,4 +8,4 @@ up:
88
- isogun
99

1010
commands:
11-
test: REDIS_HOST=ci-queue.railgun bundle exec rake test
11+
test: REDIS_URL=${REDIS_URL:-redis://ci-queue.railgun/0} bundle exec rake test

ruby/test/ci/queue/redis/test_time_record_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
class CI::Queue::Redis::TestTimeRecordTest < Minitest::Test
55
def setup
6-
redis_url = "redis://#{ENV.fetch('REDIS_HOST', 'localhost')}/7"
6+
redis_url = ENV.fetch('REDIS_URL', 'redis://localhost:6379/0')
77
redis = Redis.new(url: redis_url)
88
redis.flushdb
99

ruby/test/ci/queue/redis_supervisor_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ class CI::Queue::Redis::SupervisorTest < Minitest::Test
55
include QueueHelper
66

77
def setup
8-
@redis_url = "redis://#{ENV.fetch('REDIS_HOST', 'localhost')}/7"
8+
@redis_url = ENV.fetch('REDIS_URL', 'redis://localhost:6379/0')
99
@redis = ::Redis.new(url: @redis_url)
1010
@redis.flushdb
1111
@supervisor = supervisor

ruby/test/ci/queue/redis_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ class CI::Queue::RedisTest < Minitest::Test
55
include SharedQueueAssertions
66

77
def setup
8-
@redis_url = "redis://#{ENV.fetch('REDIS_HOST', 'localhost')}/7"
8+
@redis_url = ENV.fetch('REDIS_URL', 'redis://localhost:6379/0')
99
@redis = ::Redis.new(url: @redis_url)
1010
@redis.flushdb
1111
super

ruby/test/integration/grind_redis_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ class GrindRedisTest < Minitest::Test
66
include OutputTestHelpers
77

88
def setup
9-
@redis_url = "redis://#{ENV.fetch('REDIS_HOST', 'localhost')}/7"
9+
@redis_url = ENV.fetch('REDIS_URL', 'redis://localhost:6379/0')
1010
@redis = Redis.new(url: @redis_url)
1111
@redis.flushdb
1212
@exe = File.expand_path('../../../exe/minitest-queue', __FILE__)

ruby/test/integration/minitest_redis_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ def setup
1616
@order_path = File.expand_path('../../fixtures/log/test_order.log', __FILE__)
1717
File.delete(@order_path) if File.exist?(@order_path)
1818

19-
@redis_url = "redis://#{ENV.fetch('REDIS_HOST', 'localhost')}/7"
19+
@redis_url = ENV.fetch('REDIS_URL', 'redis://localhost:6379/0')
2020
@redis = Redis.new(url: @redis_url)
2121
@redis.flushdb
2222
@exe = File.expand_path('../../../exe/minitest-queue', __FILE__)

ruby/test/integration/rspec_redis_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ class RSpecRedisTest < Minitest::Test
66
include OutputTestHelpers
77

88
def setup
9-
@redis_url = "redis://#{ENV.fetch('REDIS_HOST', 'localhost')}/7"
9+
@redis_url = ENV.fetch('REDIS_URL', 'redis://localhost:6379/0')
1010
@redis = Redis.new(url: @redis_url)
1111
@redis.flushdb
1212
@exe = File.expand_path('../../../exe/rspec-queue', __FILE__)

ruby/test/minitest/queue/build_status_recorder_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ class BuildStatusRecorderTest < Minitest::Test
66
include ReporterTestHelper
77

88
def setup
9-
@redis_url = "redis://#{ENV.fetch('REDIS_HOST', 'localhost')}/7"
9+
@redis_url = ENV.fetch('REDIS_URL', 'redis://localhost:6379/0')
1010
@redis = ::Redis.new(url: @redis_url)
1111
@redis.flushdb
1212
@queue = worker(1)

ruby/test/minitest/queue/test_time_recorder_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
module Minitest::Queue
55
class TestTimeRecorderTest < Minitest::Test
66
def setup
7-
redis_url = "redis://#{ENV.fetch('REDIS_HOST', 'localhost')}/7"
7+
redis_url = ENV.fetch('REDIS_URL', 'redis://localhost:6379/0')
88
redis = Redis.new(url: redis_url)
99
redis.flushdb
1010

0 commit comments

Comments
 (0)