add: unicode test cases for cross-sheet names #2047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! Running the browser suite now, @janiewang26 https://app.saucelabs.com/open_sauce/user/sheetjs/tests/vdc shows the tests and https://app.saucelabs.com/open_sauce/user/sheetjs/builds shows the most recently finished builds. Once all the tests pass, merge the changes |
|
The travis fails are due to the test_files not having been updated. I can do this after merging |
janiewang26
approved these changes
Jul 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds additional
corner casestests for unicode names in worksheets being referenced in the same workbook.All the tests pass in nodejs and (should) with browser (minus the Windows exceptions).
Provides tests for the fix @mohammedsahl added (#2046)