Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Any reason for multiple SwipeUpdateCallback #60

Open
adumrewal opened this issue Nov 19, 2020 · 1 comment
Open

Any reason for multiple SwipeUpdateCallback #60

adumrewal opened this issue Nov 19, 2020 · 1 comment

Comments

@adumrewal
Copy link

In file flutter_tindercard.dart, we have multiple calls to widget.swipeUpdateCallback(details, frontCardAlign); incase (widget._allowVerticalMovement == true) is false. These are present on line 232 and 237.

Is there any particular reason why we are doing so? I want to remove the first one but just want to be sure that there won't be any regressions.
@nalbion
Copy link

nalbion commented Mar 1, 2021

I've done this in PR #65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nalbion @adumrewal