Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Existing markdown links results in double-wrapping #38

Closed
SethCohen opened this issue Oct 18, 2024 · 0 comments · Fixed by #39
Closed

Existing markdown links results in double-wrapping #38

SethCohen opened this issue Oct 18, 2024 · 0 comments · Fixed by #39
Labels
bug Something isn't working

Comments

@SethCohen
Copy link
Owner

Issue Description:

Release v1.16.0 introduced an error such as when a Release event payload body already contains a markdown version of a PR, Issue, Compare, etc, the action improperly double wraps the content as it only checks for the url link, resulting in the markdown link version failing.
index.js L50-L78

Expected Result:

expected result

Actual Result:

actual result

Solution:

Check for existing urls and markdown links before trying to convert.

@SethCohen SethCohen added the bug Something isn't working label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant