Conversation
tscholak
reviewed
Dec 4, 2024
| return metadata | ||
| path = config.path / f"metadata.yaml" | ||
| logger.warning(f"Loading metadata from {path}") | ||
| return CheckpointMetadata.from_dict(yaml.safe_load(path.open("r"))) |
Collaborator
There was a problem hiding this comment.
@charlesGE can you confirm that we don't need this anymore please?
tscholak
reviewed
Dec 4, 2024
| @pytest.mark.depends(on=["test_model_sf"]) | ||
| def test_model_sdp2(): | ||
| # Sequence-data-parallel | ||
| run_test_script( |
tscholak
approved these changes
Dec 4, 2024
Collaborator
tscholak
left a comment
tscholak
left a comment
There was a problem hiding this comment.
LGTM, but I'd like to defer to @charlesGE who should try to work with ghcr.io/servicenow/fast-llm:sha-85dfeea and see if our experiments can be continued with it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description
check_parallel_matchdebug_tensor_parallelfor sequence-tensor-parallelpresentswrongly set for the last micro-batch with sequence-data-parallel, causing a crash ([bug] Crash with sequence-data-parallel #57)tensor_and_sequence_datadistributed dim so we can reconstruct micro-sequences properly (needed for test below)🔍 Type of change
Select all that apply: