You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
"timeout" arg missing for EnvArgs to instantiate BrowserEnv is missing #273
Hi, I noticed some missing arguments in EnvArgs for instantiating BrowserGym with full configurations.
For example, timeout is not configurable in EnvArgs, and the timeout for context or page configuration can only be set by the attribute in the Task class this way.
As well as pw_chromium_kwargs, which is not that important but still incomplete for designing EnvArgs.
Hopefully, this is useful for your improvement! I've been deeply reading and reconstructing your codebase to do my experiments; I love your work, and thank you for continued updating:)
I'm not sure why we didn't include timeout in EnvArgs, it should be pretty easy to add. @recursix was there a reason why we didn't have it? Should we include all BrowserEnv parameters in EnvArgs ?
Activity
gasse commentedon Nov 25, 2024
Hi @rowingchenn , thanks for the kind words!
I'm not sure why we didn't include
timeoutinEnvArgs, it should be pretty easy to add. @recursix was there a reason why we didn't have it? Should we include allBrowserEnvparameters inEnvArgs?recursix commentedon Jul 16, 2025
Apologies for long delay. This indeed should be added in the future.