Skip to content

"timeout" arg missing for EnvArgs to instantiate BrowserEnv is missing #273

Description

@rowingchenn

Hi, I noticed some missing arguments in EnvArgs for instantiating BrowserGym with full configurations.

For example, timeout is not configurable in EnvArgs, and the timeout for context or page configuration can only be set by the attribute in the Task class this way.

As well as pw_chromium_kwargs, which is not that important but still incomplete for designing EnvArgs.

Hopefully, this is useful for your improvement! I've been deeply reading and reconstructing your codebase to do my experiments; I love your work, and thank you for continued updating:)

Activity

  1. gasse commented on Nov 25, 2024

    @gasse
    Contributor

    Hi @rowingchenn , thanks for the kind words!

    I'm not sure why we didn't include timeout in EnvArgs, it should be pretty easy to add. @recursix was there a reason why we didn't have it? Should we include all BrowserEnv parameters in EnvArgs ?

  2. recursix commented on Jul 16, 2025

    @recursix
    Collaborator

    Apologies for long delay. This indeed should be added in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

enhancementNew feature or request

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions