feat: polyfill some Exception.Throw... methods on C# 14#133
Open
nogic1008 wants to merge 5 commits intoSergio0694:mainfrom
Open
feat: polyfill some Exception.Throw... methods on C# 14#133nogic1008 wants to merge 5 commits intoSergio0694:mainfrom
Exception.Throw... methods on C# 14#133nogic1008 wants to merge 5 commits intoSergio0694:mainfrom
Conversation
- `PolySharp.OldCSharpVersion.Tests` (C# 13) does not generate polyfill - `PolySharp.Tests` generates polyfill
Exception.Throw... methods on C# 14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #132
API breakdown (for new features)
This PR implements some throw helper methods via extension members when target project is C# 14 or above.
ArgumentException.ThrowIfNullOrEmpty(string? argument, string? paramName = default)ArgumentException.ThrowIfNullOrWhiteSpace(string? argument, string? paramName = default)ArgumentNullException.ThrowIfNull(object? argument, string? paramName = default)ArgumentOutOfRangeException.ThrowIfEqual<T>(T value, T other, string? paramName = default)ArgumentOutOfRangeException.ThrowIfNotEqual<T>(T value, T other, string? paramName = default)ArgumentOutOfRangeException.ThrowIfGreaterThan<T>(T value, T other, string? paramName = default)ArgumentOutOfRangeException.ThrowIfGreaterThanOrEqual<T>(T value, T other, string? paramName = default)ArgumentOutOfRangeException.ThrowIfLessThan<T>(T value, T other, string? paramName = default)ArgumentOutOfRangeException.ThrowIfLessThanOrEqual<T>(T value, T other, string? paramName = default)ObjectDisposedException.ThrowIf(bool condition, object instance)ObjectDisposedException.ThrowIf(bool condition, Type type)This implementation is based on the one in dotnet/runtime
ArgumentNullException,ObjectDisposedExceptionArgumentExceptionArgumentOutOfRangeExceptionLimitation
INumberBase<T>interface, so these methods are not implemented.ArgumentOutOfRangeException.ThrowIfZero<T>(T value, string? paramName = null)ArgumentOutOfRangeException.ThrowIfNegative<T>(T value, string? paramName = null)ArgumentOutOfRangeException.ThrowIfNegativeOrZero<T>(T value, string? paramName = null)ArgumentNullException.ThrowIfNull.ArgumentNullException.ThrowIfNullcannot Tier0 intrinsic to avoid redundant boxing in generics because lackIntrinsicattribute.